From: Johan Hovold <johan+linaro@kernel.org>
To: Vinod Koul <vkoul@kernel.org>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Kishon Vijay Abraham I <kishon@ti.com>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Neil Armstrong <neil.armstrong@linaro.org>,
linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org,
linux-kernel@vger.kernel.org,
Johan Hovold <johan+linaro@kernel.org>
Subject: [PATCH v2 05/11] phy: qcom-qmp-pcie: move power-down update
Date: Thu, 29 Sep 2022 11:29:10 +0200 [thread overview]
Message-ID: <20220929092916.23068-6-johan+linaro@kernel.org> (raw)
In-Reply-To: <20220929092916.23068-1-johan+linaro@kernel.org>
Move the power-down-control register update that powers on the PHY to
the power-on handler so that it matches the power-off handler.
Note that the power-on handler is currently always called directly
after init.
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
---
drivers/phy/qualcomm/phy-qcom-qmp-pcie.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-pcie.c b/drivers/phy/qualcomm/phy-qcom-qmp-pcie.c
index efffb77e8f45..db78d2d76c03 100644
--- a/drivers/phy/qualcomm/phy-qcom-qmp-pcie.c
+++ b/drivers/phy/qualcomm/phy-qcom-qmp-pcie.c
@@ -1862,7 +1862,6 @@ static int qmp_pcie_init(struct phy *phy)
struct qmp_phy *qphy = phy_get_drvdata(phy);
struct qcom_qmp *qmp = qphy->qmp;
const struct qmp_phy_cfg *cfg = qphy->cfg;
- void __iomem *pcs = qphy->pcs;
int ret;
/* turn on regulator supplies */
@@ -1888,9 +1887,6 @@ static int qmp_pcie_init(struct phy *phy)
if (ret)
goto err_assert_reset;
- qphy_setbits(pcs, cfg->regs[QPHY_PCS_POWER_DOWN_CONTROL],
- cfg->pwrdn_ctrl);
-
return 0;
err_assert_reset:
@@ -1929,6 +1925,9 @@ static int qmp_pcie_power_on(struct phy *phy)
unsigned int mask, val, ready;
int ret;
+ qphy_setbits(pcs, cfg->regs[QPHY_PCS_POWER_DOWN_CONTROL],
+ cfg->pwrdn_ctrl);
+
qmp_pcie_serdes_init(qphy);
ret = clk_prepare_enable(qphy->pipe_clk);
--
2.35.1
next prev parent reply other threads:[~2022-09-29 9:30 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-29 9:29 [PATCH v2 00/11] phy: qcom-qmp: more fixes and cleanups Johan Hovold
2022-09-29 9:29 ` [PATCH v2 01/11] phy: qcom-qmp: fix obsolete lane comments Johan Hovold
2022-09-29 9:29 ` [PATCH v2 02/11] phy: qcom-qmp-combo: drop unused UFS reset Johan Hovold
2022-09-29 9:29 ` [PATCH v2 03/11] phy: qcom-qmp-pcie: drop unused common-block registers Johan Hovold
2022-09-29 9:29 ` [PATCH v2 04/11] phy: qcom-qmp-pcie: clean up power-down handling Johan Hovold
2022-09-29 10:09 ` Dmitry Baryshkov
2022-09-29 9:29 ` Johan Hovold [this message]
2022-09-29 19:05 ` [PATCH v2 05/11] phy: qcom-qmp-pcie: move power-down update Dmitry Baryshkov
2022-09-29 9:29 ` [PATCH v2 06/11] phy: qcom-qmp-pcie-msm8996: clean up power-down handling Johan Hovold
2022-09-29 10:07 ` Dmitry Baryshkov
2022-09-29 9:29 ` [PATCH v2 07/11] phy: qcom-qmp-combo: " Johan Hovold
2022-09-29 10:08 ` Dmitry Baryshkov
2022-09-29 9:29 ` [PATCH v2 08/11] phy: qcom-qmp-ufs: " Johan Hovold
2022-09-29 10:18 ` Dmitry Baryshkov
2022-09-29 9:29 ` [PATCH v2 09/11] phy: qcom-qmp-usb: " Johan Hovold
2022-09-29 10:09 ` Dmitry Baryshkov
2022-09-29 9:29 ` [PATCH v2 10/11] phy: qcom-qmp-pcie: clean up clock lists Johan Hovold
2022-09-29 10:08 ` Dmitry Baryshkov
2022-09-29 9:29 ` [PATCH v2 11/11] phy: qcom-qmp-pcie: drop bogus register update Johan Hovold
2022-09-29 10:18 ` Dmitry Baryshkov
2022-09-29 12:39 ` Johan Hovold
2022-09-30 10:57 ` Dmitry Baryshkov
2022-09-30 11:25 ` Johan Hovold
2022-09-29 9:47 ` [PATCH v2 00/11] phy: qcom-qmp: more fixes and cleanups Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220929092916.23068-6-johan+linaro@kernel.org \
--to=johan+linaro@kernel.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=kishon@ti.com \
--cc=konrad.dybcio@somainline.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=neil.armstrong@linaro.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox