Re: [PATCH v10 2/2] testing: use the copyleft-next-0.3.1 SPDX tag

Kees Cook
2022-10-01T14:58:16Z

On Tue, Sep 13, 2022 at 11:01:47PM -0700, Luis Chamberlain wrote:
> Two selftests drivers exist under the copyleft-next license.
> These drivers were added prior to SPDX practice taking full swing
> in the kernel. Now that we have an SPDX tag for copylef-next-0.3.1

nit: copylef -> copyleft

> documented, embrace it and remove the boiler plate.
>
> Cc: Goldwyn Rodrigues <rgoldwyn@suse.com>
> Cc: Kuno Woudt <kuno@frob.nl>
> Cc: Richard Fontana <fontana@sharpeleven.org>
> Cc: copyleft-next@lists.fedorahosted.org
> Cc: Ciaran Farrell <Ciaran.Farrell@suse.com>
> Cc: Christopher De Nicolo <Christopher.DeNicolo@suse.com>
> Cc: Christoph Hellwig <hch@lst.de>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Jonathan Corbet <corbet@lwn.net>
> Cc: Thorsten Leemhuis <linux@leemhuis.info>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
> ---
> lib/test_kmod.c | 12 +-----------
> lib/test_sysctl.c | 12 +-----------
> tools/testing/selftests/kmod/kmod.sh | 13 +------------
> tools/testing/selftests/sysctl/sysctl.sh | 12 +-----------
> 4 files changed, 4 insertions(+), 45 deletions(-)

Reviewed-by: Kees Cook <keescook@chromium.org>

Always nice to see more lines removed than added. :)

--
Kees Cook