Re: [PATCH 5.15 00/83] 5.15.72-rc1 review

Greg Kroah-Hartman
2022-10-04T17:46:10Z

On Mon, Oct 03, 2022 at 07:26:40AM -0700, Guenter Roeck wrote:
> On 10/3/22 00:10, Greg Kroah-Hartman wrote:
> > This is the start of the stable review cycle for the 5.15.72 release.
> > There are 83 patches in this series, all will be posted as a response
> > to this one. If anyone has any issues with these being applied, please
> > let me know.
> >
> > Responses should be made by Wed, 05 Oct 2022 07:07:06 +0000.
> > Anything received after that time might be too late.
> >
>
> perf fails to build.
>
> In file included from util/evlist.h:13,
> from builtin-annotate.c:21:
> util/evsel.h:266:38: error: ‘PERF_TOOL_MAX’ undeclared here (not in a function); did you mean ‘PERF_TXN_MAX’?
> 266 | extern const char *evsel__tool_names[PERF_TOOL_MAX];
> | ^~~~~~~~~~~~~
> | PERF_TXN_MAX
> In file included from util/hist.h:8,
> from builtin-diff.c:13:
> util/evsel.h:266:38: error: ‘PERF_TOOL_MAX’ undeclared here (not in a function); did you mean ‘PERF_TXN_MAX’?
> 266 | extern const char *evsel__tool_names[PERF_TOOL_MAX];
> | ^~~~~~~~~~~~~
> | PERF_TXN_MAX
> In file included from util/evlist.h:13,
> from builtin-evlist.c:11:
> util/evsel.h:266:38: error: ‘PERF_TOOL_MAX’ undeclared here (not in a function); did you mean ‘PERF_TXN_MAX’?
> 266 | extern const char *evsel__tool_names[PERF_TOOL_MAX];
> | ^~~~~~~~~~~~~
> | PERF_TXN_MAX
> In file included from tools/perf/util/evlist.h:13,
> from builtin-ftrace.c:24:
> tools/perf/util/evsel.h:266:38: error: ‘PERF_TOOL_MAX’ undeclared here (not in a function); did you mean ‘PERF_TXN_MAX’?
> 266 | extern const char *evsel__tool_names[PERF_TOOL_MAX];
> | ^~~~~~~~~~~~~
> | PERF_TXN_MAX
> builtin-annotate.c: In function ‘cmd_annotate’:
> builtin-annotate.c:594:8: error: implicit declaration of function ‘symbol__validate_sym_arguments’ [-Werror=implicit-function-declaration]
> 594 | ret = symbol__validate_sym_arguments();
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Thanks, I've dropped all perf patches from the 5.15 queue right now as
they seem to have been added incorrectly.

That being said, I can't build perf for 5.15.y now anyway, so something
older must have broken my system, glad it's building for you...

thanks

greg k-h