From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD4E6C433FE for ; Mon, 3 Oct 2022 08:23:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230496AbiJCIXD (ORCPT ); Mon, 3 Oct 2022 04:23:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46332 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230329AbiJCIWS (ORCPT ); Mon, 3 Oct 2022 04:22:18 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EF00C13D61 for ; Mon, 3 Oct 2022 00:56:46 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id 11D0367373; Mon, 3 Oct 2022 09:17:19 +0200 (CEST) Date: Mon, 3 Oct 2022 09:17:18 +0200 From: Christoph Hellwig To: Al Viro Cc: ira.weiny@intel.com, Jens Wiklander , Sumit Garg , Andrew Morton , "Fabio M. De Francesco" , Christoph Hellwig , Linus Torvalds , op-tee@lists.trustedfirmware.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 3/4] tee: Remove call to get_kernel_pages() Message-ID: <20221003071718.GA1986@lst.de> References: <20221002002326.946620-1-ira.weiny@intel.com> <20221002002326.946620-4-ira.weiny@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Oct 02, 2022 at 01:46:41AM +0100, Al Viro wrote: > IDGI. The only thing in kiov[...] you are every reading is > ->iov_base. And you fetch it once, right after the assignment. ... and that's exactly what I pointed out on the last version of the patch ...