From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9E4CC433FE for ; Mon, 3 Oct 2022 18:06:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229941AbiJCSG2 (ORCPT ); Mon, 3 Oct 2022 14:06:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48364 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229880AbiJCSGY (ORCPT ); Mon, 3 Oct 2022 14:06:24 -0400 Received: from mail-pf1-x42d.google.com (mail-pf1-x42d.google.com [IPv6:2607:f8b0:4864:20::42d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 382A513E33 for ; Mon, 3 Oct 2022 11:06:22 -0700 (PDT) Received: by mail-pf1-x42d.google.com with SMTP id u21so5220299pfc.13 for ; Mon, 03 Oct 2022 11:06:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date; bh=pIzTmQpobMdvo8GfKaRW2/roCkTNS3D5pBPTXA+12i8=; b=SXA4C8zlP/H6XYd9Wus6gRGtSyRucd9T6u9HfOHffXz/P69o11Ry2w00sgWnrMs5Xk wyVtfRqObDML4/alrBwbIuF3aYbADtN6HUCQ5qukqpvVWDlU7j9zT9EIV5AApI/1J1QH 83iN0ga1Tm78Y3rGKi7ExlccIx4e25wNLa/oc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=pIzTmQpobMdvo8GfKaRW2/roCkTNS3D5pBPTXA+12i8=; b=0NqSMzHtCAIWErniFwk7d3SDgMclcMutqXyMH6NBngFSvHQf8w7dGfUQtU3SGj3nPa oKZWkVnnqUnl5dFFWrTDpeeYfdg5Gm1rlMbW6mdtJg2hG5HeJpgOJrJaFLtbG7uaMIXA gRsZ2fhAQPJRhpb7Qic0aXN5wa84nHQKMg+aHg1Y+INCN+OFhdchxUrkFUvRKFNVlsu8 h62I8/5BtabSEJyTD2JDpAifx0b1pnvO/w2O7Y/KkPD+ArdNLPE9y0He9x9NHHro4i27 6KjObcfJ0W5L1FRFWTSt2bbib8azrKekMJlO72Q9/bQouLrlxdOqbu78HsNWTV/Cf161 LeaQ== X-Gm-Message-State: ACrzQf0Hii8ZkskN2oEQDgm7qCljp2AmjCQ2Bqn51bZb7fB1xbdq0W0C +jsPU2crCvpqNrYjnc+h72jyHQ== X-Google-Smtp-Source: AMsMyM5neqQ02uhM3tW616MWu61HS4Vdqno2CVR6UnaXvvhzpp2blmFWahTxoonexAZ1EXGCH3aHSg== X-Received: by 2002:a05:6a00:4c11:b0:53e:4f07:fce9 with SMTP id ea17-20020a056a004c1100b0053e4f07fce9mr24392025pfb.66.1664820381761; Mon, 03 Oct 2022 11:06:21 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id x2-20020aa79562000000b0053dec787698sm4474742pfq.175.2022.10.03.11.06.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Oct 2022 11:06:20 -0700 (PDT) Date: Mon, 3 Oct 2022 11:06:19 -0700 From: Kees Cook To: Rick Edgecombe Cc: x86@kernel.org, "H . Peter Anvin" , Thomas Gleixner , Ingo Molnar , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-api@vger.kernel.org, Arnd Bergmann , Andy Lutomirski , Balbir Singh , Borislav Petkov , Cyrill Gorcunov , Dave Hansen , Eugene Syromiatnikov , Florian Weimer , "H . J . Lu" , Jann Horn , Jonathan Corbet , Mike Kravetz , Nadav Amit , Oleg Nesterov , Pavel Machek , Peter Zijlstra , Randy Dunlap , "Ravi V . Shankar" , Weijiang Yang , "Kirill A . Shutemov" , joao.moreira@intel.com, John Allen , kcc@google.com, eranian@google.com, rppt@kernel.org, jamorris@linux.microsoft.com, dethoma@microsoft.com, Yu-cheng Yu Subject: Re: [PATCH v2 09/39] x86/mm: Move pmd_write(), pud_write() up in the file Message-ID: <202210031105.39AA8FE@keescook> References: <20220929222936.14584-1-rick.p.edgecombe@intel.com> <20220929222936.14584-10-rick.p.edgecombe@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220929222936.14584-10-rick.p.edgecombe@intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 29, 2022 at 03:29:06PM -0700, Rick Edgecombe wrote: > From: Yu-cheng Yu > > To prepare the introduction of _PAGE_COW, move pmd_write() and > pud_write() up in the file, so that they can be used by other > helpers below. No functional changes. > > Signed-off-by: Yu-cheng Yu Hey, a PTE patch I'm able to review! ;) Reviewed-by: Kees Cook -- Kees Cook