Re: [PATCH 12/12] dt-bindings: mediatek: mt8188: add mt8188-mt6359 document

Rob Herring
2022-10-03T16:39:04Z

On Fri, Sep 30, 2022 at 10:57:01PM +0800, Trevor Wu wrote:
> Add document for mt8188 board with mt6359.
>
> Signed-off-by: Trevor Wu <trevor.wu@mediatek.com>
> ---
> .../bindings/sound/mt8188-mt6359.yaml | 70 +++++++++++++++++++
> 1 file changed, 70 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/sound/mt8188-mt6359.yaml
>
> diff --git a/Documentation/devicetree/bindings/sound/mt8188-mt6359.yaml b/Documentation/devicetree/bindings/sound/mt8188-mt6359.yaml
> new file mode 100644
> index 000000000000..57c7c5ceef8a
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/mt8188-mt6359.yaml
> @@ -0,0 +1,70 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/sound/mt8188-mt6359.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: MediaTek MT8188 ASoC sound card driver
> +
> +maintainers:
> + - Trevor Wu <trevor.wu@mediatek.com>
> +
> +description:
> + This binding describes the MT8188 sound card.
> +
> +properties:
> + compatible:
> + enum:
> + - mediatek,mt8188-sound
> +
> + model:
> + $ref: /schemas/types.yaml#/definitions/string
> + description: User specified audio sound card name
> +
> + audio-routing:
> + $ref: /schemas/types.yaml#/definitions/non-unique-string-array
> + description:
> + A list of the connections between audio components. Each entry is a
> + sink/source pair of strings. Valid names could be the input or output
> + widgets of audio components, power supplies, MicBias of codec and the
> + software switch.
> +
> + mediatek,platform:
> + $ref: "/schemas/types.yaml#/definitions/phandle"

Don't need quotes.

> + description: The phandle of MT8188 ASoC platform.
> +
> + mediatek,dptx-codec:
> + $ref: "/schemas/types.yaml#/definitions/phandle"
> + description: The phandle of MT8188 Display Port Tx codec node.
> +
> + mediatek,hdmi-codec:
> + $ref: "/schemas/types.yaml#/definitions/phandle"
> + description: The phandle of MT8188 HDMI codec node.
> +
> + mediatek,dai-link:
> + $ref: /schemas/types.yaml#/definitions/string-array
> + description:
> + A list of the desired dai-links in the sound card. Each entry is a
> + name defined in the machine driver.

Names have to be defined here.

> +
> +additionalProperties: false
> +
> +required:
> + - compatible
> + - mediatek,platform
> +
> +examples:
> + - |
> +
> + sound: mt8188-sound {
> + compatible = "mediatek,mt8188-sound";
> + mediatek,platform = <&afe>:
> + pinctrl-names = "default";
> + pinctrl-0 = <&aud_pins_default>;
> + audio-routing =
> + "Headphone", "Headphone L",
> + "Headphone", "Headphone R",
> + "AIN1", "Headset Mic";
> + };
> +
> +...
> --
> 2.18.0
>
>