From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56F52C433FE for ; Mon, 3 Oct 2022 17:07:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229719AbiJCRGy (ORCPT ); Mon, 3 Oct 2022 13:06:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57972 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229666AbiJCRGs (ORCPT ); Mon, 3 Oct 2022 13:06:48 -0400 Received: from mail-lj1-x22b.google.com (mail-lj1-x22b.google.com [IPv6:2a00:1450:4864:20::22b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F329B2CCA3 for ; Mon, 3 Oct 2022 10:06:39 -0700 (PDT) Received: by mail-lj1-x22b.google.com with SMTP id l14so2432718lja.8 for ; Mon, 03 Oct 2022 10:06:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf.com; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=r0Z5yE/2rNF+pvpyQXUAi3Xvmkjk0yqwlZznS4MM2b4=; b=bau++nGklIo7U08JXPGNo3iOg9p0MFPrhIGm0KZl+ya7g2hPNx7gGTLCiIuVKymW3y Cn33CpKQaCpuXY297INCjISDyjOnMyXKZawwlAC6UsW1zHLOrUcJGHoEOpf5SxNbhfW9 HnLTGTbwhVN3mek7dbcybwTPKSYXhuS/35AQyKT9J6XoRNG15VlkkDQgHy1azjXp12pA mWeprimevmA4Jf3l7W9MvnwcYFpCGHxA9p38NS1ZqMyELUnyejIkKwvCp8w+lzIuQidV nMbmPQRcjScml/4s0F0rBwKzmFLw8PqwzYRjTOHJdQcVLW7QTohqJxipR9fAOt7PJpX5 DTgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=r0Z5yE/2rNF+pvpyQXUAi3Xvmkjk0yqwlZznS4MM2b4=; b=z6qlsMaeZPwPh9aSpyHjE1XSr2dGnuAETS2MK0bxwQWakS4u1xJLSp+zDlaVx3SWRn lQeMiCW/rFJMQ2ttcqASEUMgCLEDDplGCL8oDbv2nzopnLHRhtJkG0AXlZcFbEZYBPLU 08pG7AP6UKHwu/lI+kVxLqG2+H2ca4d8Qp3xYtmWbEgpH/QpT3AaeZDsR5woE7itA65I cca5oMCG7KVfpnaxSu+spfBrLZ3PoS6fnXHRsstp2M6th9z37JsXuEflrB+cKA1LIGjF TRhpnaJhaa2VBUCpU8qgpgkYGvk1A3lSjgkpSnhf9vMlJzxS70t/sSTUxA8dj1tMlvpL BZCA== X-Gm-Message-State: ACrzQf0EFLoV+EBbktikLMqIj1IdQwT2uvG++/YK9yWvjL488pzK1JVf YiZwzY7piCUse0Z1ucAcEVdXYg== X-Google-Smtp-Source: AMsMyM7TbQ/E+ZeZ5oQBBxqIr8itrpHEL8mApGbB0maUJCo2oyUmFAOIHhyw+pcmNK06WwQGFr+9bw== X-Received: by 2002:a2e:80d4:0:b0:26d:e557:a9ca with SMTP id r20-20020a2e80d4000000b0026de557a9camr858442ljg.311.1664816797323; Mon, 03 Oct 2022 10:06:37 -0700 (PDT) Received: from fedora.. ([78.10.207.2]) by smtp.gmail.com with ESMTPSA id z3-20020a056512370300b004a2386b8cebsm659145lfr.210.2022.10.03.10.06.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Oct 2022 10:06:36 -0700 (PDT) From: =?UTF-8?q?Micha=C5=82=20Grzelak?= To: mw@semihalf.com Cc: davem@davemloft.net, devicetree@vger.kernel.org, edumazet@google.com, krzysztof.kozlowski+dt@linaro.org, krzysztof.kozlowski@linaro.org, kuba@kernel.org, linux-kernel@vger.kernel.org, linux@armlinux.org.uk, mig@semihalf.com, netdev@vger.kernel.org, pabeni@redhat.com, robh+dt@kernel.org, upstream@semihalf.com Subject: Re: [PATCH v2] dt-bindings: net: marvell,pp2: convert to json-schema Date: Mon, 3 Oct 2022 19:06:13 +0200 Message-Id: <20221003170613.132548-1-mig@semihalf.com> X-Mailer: git-send-email 2.37.3 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/10/2022 10:23, Marcin Wojtas wrote: >niedz., 2 paź 2022 o 10:00 Krzysztof Kozlowski > napisał(a): >> >> On 01/10/2022 17:53, Michał Grzelak wrote: >> > Hi Krzysztof, >> > >> > Thanks for your comments and time spent on reviewing my patch. >> > All of those improvements will be included in next version. >> > Also, I would like to know your opinion about one. >> > >> >>> + >> >>> + marvell,system-controller: >> >>> + $ref: /schemas/types.yaml#/definitions/phandle >> >>> + description: a phandle to the system controller. >> >>> + >> >>> +patternProperties: >> >>> + '^eth[0-9a-f]*(@.*)?$': >> >> >> >> The name should be "(ethernet-)?port", unless anything depends on >> >> particular naming? >> > >> > What do you think about pattern "^(ethernet-)?eth[0-9a-f]+(@.*)?$"? >> > It resembles pattern found in net/ethernet-phy.yaml like >> > properties:$nodename:pattern:"^ethernet-phy(@[a-f0-9]+)?$", while >> > still passing `dt_binding_check' and `dtbs_check'. It should also >> > comply with your comment. >> >> Node names like ethernet-eth do not make much sense because they contain >> redundant ethernet or eth. AFAIK, all other bindings like that call >> these ethernet-ports (or sometimes shorter - ports). Unless this device >> is different than all others? >> > >IMO "^(ethernet-)?port@[0-9]+$" for the subnodes' names could be fine >(as long as we don't have to modify the existing .dtsi files) - there >is no dependency in the driver code on that. Indeed, driver's code isn't dependent; however, there is a dependency on 'eth[0-2]' name in all relevant .dts and .dtsi files, e.g.: https://github.com/torvalds/linux/blob/master/arch/arm/boot/dts/armada-375.dtsi#L190 https://github.com/torvalds/linux/blob/master/arch/arm64/boot/dts/marvell/armada-cp11x.dtsi#L72 Ports under 'ethernet' node are named eth[0-2], thus those and all .dts files including the above would have to be modified to pass through `dtbs_check'. Best regards, Michał