From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9044C433F5 for ; Fri, 7 Oct 2022 23:17:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229689AbiJGXRn (ORCPT ); Fri, 7 Oct 2022 19:17:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49224 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229511AbiJGXRk (ORCPT ); Fri, 7 Oct 2022 19:17:40 -0400 Received: from mail-pl1-x62d.google.com (mail-pl1-x62d.google.com [IPv6:2607:f8b0:4864:20::62d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EBADD8B2C2 for ; Fri, 7 Oct 2022 16:17:37 -0700 (PDT) Received: by mail-pl1-x62d.google.com with SMTP id 10so5880958pli.0 for ; Fri, 07 Oct 2022 16:17:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=3VntPma6h9YXldWusKRirKa+AxvzlFLxSpnoOOvfbEY=; b=Lw5fVRNuMGTXDOBUV8sWh1sbwxiATNyFn5sU8LQHGlrdcjl2RO1zQMGM4h2Tmbbrg/ dzR4AX2LEsdqHpEtq2VXT1AktDCi/eAxuoTHKd+2004AmAbkDVEQ2gpm5lwFjwdNDPKc hc/pJ0qDS8e7vs4IkKY5iNoPL2VqtIZCdDMlc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=3VntPma6h9YXldWusKRirKa+AxvzlFLxSpnoOOvfbEY=; b=vadaXPbWZnInWhTaIKn20zvJwGPki3t4OCm9U27gHrltKiww25TkzsvzWwSPKGIf37 ihKaq+yR8jMFkNrqVWAzNbwvKdXVYV4MIB73+lgAo9DzL8af5ruSPINaYaRYapobIII7 rQpw4nmG8pR18vqVB1jamTMr259q+vX4vz99TpmQO02ioSZs0Upo1yP2ajoVrRyna5rR WmptKnF08WfPjOMLMbs0iN5CDv1nS/870X+ZXAkTwWeRDwRxFRJAsjugk/e5v8EJdD6D WUS2D1otKvYhGZXqKnPEL3RCdrwduAPomE/mqy2diw5ov3pVgVIhKnBV65Gv3jLXmzOD BfTw== X-Gm-Message-State: ACrzQf1PNmw/NJehkDIcgwuEAKMYcUhtfG/u+6nBHLAGyBnuKrGH88lR zbRYFkuJBU4iZeOhLCRCJj6K6A== X-Google-Smtp-Source: AMsMyM6dsbNeWBcjJm9aRIb7GnG5PGfyHyuEE4bQKFj2jK/3xPcKVdrwJUFENovkupK3JRiP3BgzWw== X-Received: by 2002:a17:902:b182:b0:178:8977:4013 with SMTP id s2-20020a170902b18200b0017889774013mr6762196plr.27.1665184657464; Fri, 07 Oct 2022 16:17:37 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id z5-20020a623305000000b00562a0c8a195sm2155931pfz.69.2022.10.07.16.17.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Oct 2022 16:17:36 -0700 (PDT) Date: Fri, 7 Oct 2022 16:17:35 -0700 From: Kees Cook To: Arnd Bergmann Cc: Nick Desaulniers , linux-fsdevel@vger.kernel.org, Alexander Viro , Andrew Morton , Andi Kleen , Christoph Hellwig , Eric Dumazet , "Darrick J. Wong" , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, llvm@lists.linux.dev, Paul Kirth Subject: Re: [PATCH] fs/select: avoid clang stack usage warning Message-ID: <202210071614.4297AB65D8@keescook> References: <20190307090146.1874906-1-arnd@arndb.de> <20221006222124.aabaemy7ofop7ccz@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 07, 2022 at 11:42:51PM +0200, Arnd Bergmann wrote: > On Fri, Oct 7, 2022, at 9:04 PM, Nick Desaulniers wrote: > > On Fri, Oct 7, 2022 at 1:28 AM Arnd Bergmann wrote: > >> - The behavior of -ftrivial-auto-var-init= is a bit odd here: with =zero or > >> =pattern, the stack usage is just below the limit (1020), without the > >> option it is up to 1044. It looks like your .config picks =zero, which > >> was dropped in the latest clang version, so it falls back to not > > > > Huh? What do you mean by "was dropped?" > > > > The config I sent has: > > CONFIG_CC_HAS_AUTO_VAR_INIT_PATTERN=y > > CONFIG_CC_HAS_AUTO_VAR_INIT_ZERO_BARE=y > > CONFIG_CC_HAS_AUTO_VAR_INIT_ZERO=y > > # CONFIG_INIT_STACK_NONE is not set > > CONFIG_INIT_STACK_ALL_ZERO=y > > When I use this config on my kernel tree (currently on top of > next-20220929 for unrelated work) and build with clang-16, > CONFIG_CC_HAS_AUTO_VAR_INIT_ZERO is disabled, so it falls > back from CONFIG_INIT_STACK_NONE instead of the unavailable > CONFIG_INIT_STACK_ALL_ZERO. I think you have a very recent Clang but are building a tree that doesn't have commit 607e57c6c62c ("hardening: Remove Clang's enable flag for -ftrivial-auto-var-init=zero"). -- Kees Cook