From: Kees Cook <keescook@chromium.org>
To: Li Zetao <lizetao1@huawei.com>
Cc: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com,
kirill.shutemov@linux.intel.com, akpm@linux-foundation.org,
michael.roth@amd.com, nathan@kernel.org,
sathyanarayanan.kuppuswamy@linux.intel.com, masahiroy@kernel.org,
ndesaulniers@google.com, brijesh.singh@amd.com,
peterz@infradead.org, venu.busireddy@oracle.com,
linux-kernel@vger.kernel.org
Subject: Re: Ping: [PATCH -next v3 0/2] Remove unused variables in x86/boot
Date: Sun, 9 Oct 2022 08:17:20 -0700 [thread overview]
Message-ID: <202210090815.526C76396@keescook> (raw)
In-Reply-To: <43ebb21e-a445-748f-f78b-51535a8384c1@huawei.com>
On Sat, Oct 08, 2022 at 09:41:59PM +0800, Li Zetao wrote:
> On 2022/9/30 11:27, Li Zetao wrote:
> > This series removes some unused variables in x86/boot, and add the
> > "-Wall" flag to Makefile, which is the old problem of x86 not sharing
> > makefiles.
> >
> > Changes since v2:
> > - Add "frame-address" flag and "-std=gnu11" to
> > x86/boot/compressed/Makefile to fix warnings when "-Wall" flag added.
> > - Declare the variable "i" within the for loop to reslove unused
> > variable warning.
> > - Delete __efi_get_rsdp_addr function when CONFIG_EFI is disabled to
> > resolve unused function warning.
Nathan suggested earlier (and I agree): please re-order these patches so
the fixes for the new warnings are first, and then turn on the compiler
flags in a final patch. This will keep the build "warning free" at all
steps.
--
Kees Cook
next prev parent reply other threads:[~2022-10-09 15:17 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-27 8:15 [PATCH -next v2 0/2] Remove unused variables in x86/boot Li Zetao
2022-09-27 8:15 ` [PATCH -next v2 1/2] x86/boot/compressed: Add "-Wall" flag to Makefile Li Zetao
2022-09-27 8:15 ` [PATCH -next v2 2/2] x86/boot: Remove unused variables Li Zetao
2022-09-27 21:50 ` [PATCH -next v2 0/2] Remove unused variables in x86/boot Nathan Chancellor
2022-09-27 21:58 ` Nathan Chancellor
2022-09-29 2:16 ` Li Zetao
2022-09-29 16:59 ` Nathan Chancellor
2022-09-30 3:27 ` [PATCH -next v3 " Li Zetao
2022-09-30 3:27 ` [PATCH -next v3 1/2] x86/boot/compressed: Add "-Wall" flag to Makefile Li Zetao
2022-09-30 3:27 ` [PATCH -next v3 2/2] x86/boot: Remove unused variables Li Zetao
2022-10-08 13:41 ` Ping: [PATCH -next v3 0/2] Remove unused variables in x86/boot Li Zetao
2022-10-09 15:17 ` Kees Cook [this message]
2022-10-11 1:29 ` [PATCH -next v4 " Li Zetao
2022-10-11 1:29 ` [PATCH -next v4 1/2] x86/boot: Remove unused variables Li Zetao
2022-10-11 21:15 ` Nick Desaulniers
2022-10-11 21:22 ` Nick Desaulniers
2022-10-11 1:29 ` [PATCH -next v4 2/2] x86/boot/compressed: Add "-Wall" flag to Makefile Li Zetao
2022-10-11 21:20 ` Nick Desaulniers
2022-10-17 17:01 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202210090815.526C76396@keescook \
--to=keescook@chromium.org \
--cc=akpm@linux-foundation.org \
--cc=bp@alien8.de \
--cc=brijesh.singh@amd.com \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizetao1@huawei.com \
--cc=masahiroy@kernel.org \
--cc=michael.roth@amd.com \
--cc=mingo@redhat.com \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=peterz@infradead.org \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
--cc=tglx@linutronix.de \
--cc=venu.busireddy@oracle.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox