From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7642C433F5 for ; Sun, 9 Oct 2022 17:59:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230156AbiJIR7l (ORCPT ); Sun, 9 Oct 2022 13:59:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43618 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230012AbiJIR7g (ORCPT ); Sun, 9 Oct 2022 13:59:36 -0400 Received: from 1wt.eu (wtarreau.pck.nerim.net [62.212.114.60]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 14733B6; Sun, 9 Oct 2022 10:59:31 -0700 (PDT) Received: (from willy@localhost) by pcw.home.local (8.15.2/8.15.2/Submit) id 299HxKtH028913; Sun, 9 Oct 2022 19:59:20 +0200 Date: Sun, 9 Oct 2022 19:59:20 +0200 From: Willy Tarreau To: Alexey Dobriyan Cc: lkp@intel.com, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, "Paul E. McKenney" Subject: Re: tools/nolibc: fix missing strlen() definition and infinite loop with gcc-12 Message-ID: <20221009175920.GA28685@1wt.eu> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Alexey, On Sun, Oct 09, 2022 at 06:45:49PM +0300, Alexey Dobriyan wrote: > Willy Tarreau wrote: > > +#if defined(__GNUC__) && (__GNUC__ >= 12) > > +__attribute__((optimize("no-tree-loop-distribute-patterns"))) > > +#endif > > static __attribute__((unused)) > > -size_t nolibc_strlen(const char *str > > I'd suggest to use asm("") in the loop body. It worked in the past > to prevent folding division loop back into division instruction. Ah excellent idea! I initially thought about using asm() to hide a variable provenance but didn't like it much because it undermines code optimization. But you're right, with an empty asm() statement alone, the loop will not look like an strlen() anymore. Just tried and it works like a charm, I'll resend a patch so that we can get rid of the ugly ifdef. > Or switch to > > size_t f(const char *s) > { > const char *s0 = s; > while (*s++) > ; > return s - s0 - 1; > } > > which compiles to 1 branch, not 2. In fact it depends. In the original code that approach was part of the ones I had considered, but it doesn't always in better code due to the prologue and epilogue being larger. It's only better at -O1, and -O2, but not -Os, and once you add asm() into it, only -O1 remains better: $ nm --size len.o|grep O|rev|sort|rev 000000000000001a T len_while_O1 0000000000000022 T len_while_asm_O1 0000000000000026 T len_for_O1 000000000000001a T len_while_O2 000000000000002b T len_while_asm_O2 0000000000000021 T len_for_O2 0000000000000013 T len_while_Os 0000000000000015 T len_while_asm_Os 000000000000000e T len_for_Os This observation seems consistent for me on x86_64, i386, arm and arm64. > But of course they could recognise this pattern too. Yes definitely, hence the need for asm() there as well to complete the comparison. Thanks for the suggestion, I'll send a v2 shortly. Willy