* [PATCH] selftests/ftrace: fix dynamic_events dependency check
@ 2022-10-10 7:42 Sven Schnelle
2022-10-12 11:12 ` Steven Rostedt
2022-10-12 11:21 ` Masami Hiramatsu
0 siblings, 2 replies; 3+ messages in thread
From: Sven Schnelle @ 2022-10-10 7:42 UTC (permalink / raw)
To: Steven Rostedt
Cc: Ingo Molnar, Shuah Khan, Masami Hiramatsu (Google),
linux-kselftest, linux-kernel
commit 95c104c378dc ("tracing: Auto generate event name when creating a
group of events") changed the syntax in the ftrace README file which is
used by the selftests to check what features are support. Adjust the
string to make test_duplicates.tc and trigger-synthetic-eprobe.tc work
again.
Fixes: 95c104c378dc ("tracing: Auto generate event name when creating a group of events")
Signed-off-by: Sven Schnelle <svens@linux.ibm.com>
---
.../testing/selftests/ftrace/test.d/dynevent/test_duplicates.tc | 2 +-
.../test.d/trigger/inter-event/trigger-synthetic-eprobe.tc | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/testing/selftests/ftrace/test.d/dynevent/test_duplicates.tc b/tools/testing/selftests/ftrace/test.d/dynevent/test_duplicates.tc
index db522577ff78..d3a79da215c8 100644
--- a/tools/testing/selftests/ftrace/test.d/dynevent/test_duplicates.tc
+++ b/tools/testing/selftests/ftrace/test.d/dynevent/test_duplicates.tc
@@ -1,7 +1,7 @@
#!/bin/sh
# SPDX-License-Identifier: GPL-2.0
# description: Generic dynamic event - check if duplicate events are caught
-# requires: dynamic_events "e[:[<group>/]<event>] <attached-group>.<attached-event> [<args>]":README
+# requires: dynamic_events "e[:[<group>/][<event>]] <attached-group>.<attached-event> [<args>]":README
echo 0 > events/enable
diff --git a/tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-synthetic-eprobe.tc b/tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-synthetic-eprobe.tc
index 914fe2e5d030..6461c375694f 100644
--- a/tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-synthetic-eprobe.tc
+++ b/tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-synthetic-eprobe.tc
@@ -1,7 +1,7 @@
#!/bin/sh
# SPDX-License-Identifier: GPL-2.0
# description: event trigger - test inter-event histogram trigger eprobe on synthetic event
-# requires: dynamic_events synthetic_events events/syscalls/sys_enter_openat/hist "e[:[<group>/]<event>] <attached-group>.<attached-event> [<args>]":README
+# requires: dynamic_events synthetic_events events/syscalls/sys_enter_openat/hist "e[:[<group>/][<event>]] <attached-group>.<attached-event> [<args>]":README
echo 0 > events/enable
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] selftests/ftrace: fix dynamic_events dependency check
2022-10-10 7:42 [PATCH] selftests/ftrace: fix dynamic_events dependency check Sven Schnelle
@ 2022-10-12 11:12 ` Steven Rostedt
2022-10-12 11:21 ` Masami Hiramatsu
1 sibling, 0 replies; 3+ messages in thread
From: Steven Rostedt @ 2022-10-12 11:12 UTC (permalink / raw)
To: Sven Schnelle
Cc: Ingo Molnar, Shuah Khan, Masami Hiramatsu (Google),
linux-kselftest, linux-kernel, Shuah Khan, Shuah Khan
On Mon, 10 Oct 2022 09:42:07 +0200
Sven Schnelle <svens@linux.ibm.com> wrote:
> commit 95c104c378dc ("tracing: Auto generate event name when creating a
> group of events") changed the syntax in the ftrace README file which is
> used by the selftests to check what features are support. Adjust the
> string to make test_duplicates.tc and trigger-synthetic-eprobe.tc work
> again.
>
> Fixes: 95c104c378dc ("tracing: Auto generate event name when creating a group of events")
> Signed-off-by: Sven Schnelle <svens@linux.ibm.com>
Acked-by: Steven Rostedt (Google) <rostedt@goodmis.org>
-- Steve
> ---
> .../testing/selftests/ftrace/test.d/dynevent/test_duplicates.tc | 2 +-
> .../test.d/trigger/inter-event/trigger-synthetic-eprobe.tc | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/testing/selftests/ftrace/test.d/dynevent/test_duplicates.tc b/tools/testing/selftests/ftrace/test.d/dynevent/test_duplicates.tc
> index db522577ff78..d3a79da215c8 100644
> --- a/tools/testing/selftests/ftrace/test.d/dynevent/test_duplicates.tc
> +++ b/tools/testing/selftests/ftrace/test.d/dynevent/test_duplicates.tc
> @@ -1,7 +1,7 @@
> #!/bin/sh
> # SPDX-License-Identifier: GPL-2.0
> # description: Generic dynamic event - check if duplicate events are caught
> -# requires: dynamic_events "e[:[<group>/]<event>] <attached-group>.<attached-event> [<args>]":README
> +# requires: dynamic_events "e[:[<group>/][<event>]] <attached-group>.<attached-event> [<args>]":README
>
> echo 0 > events/enable
>
> diff --git a/tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-synthetic-eprobe.tc b/tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-synthetic-eprobe.tc
> index 914fe2e5d030..6461c375694f 100644
> --- a/tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-synthetic-eprobe.tc
> +++ b/tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-synthetic-eprobe.tc
> @@ -1,7 +1,7 @@
> #!/bin/sh
> # SPDX-License-Identifier: GPL-2.0
> # description: event trigger - test inter-event histogram trigger eprobe on synthetic event
> -# requires: dynamic_events synthetic_events events/syscalls/sys_enter_openat/hist "e[:[<group>/]<event>] <attached-group>.<attached-event> [<args>]":README
> +# requires: dynamic_events synthetic_events events/syscalls/sys_enter_openat/hist "e[:[<group>/][<event>]] <attached-group>.<attached-event> [<args>]":README
>
> echo 0 > events/enable
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] selftests/ftrace: fix dynamic_events dependency check
2022-10-10 7:42 [PATCH] selftests/ftrace: fix dynamic_events dependency check Sven Schnelle
2022-10-12 11:12 ` Steven Rostedt
@ 2022-10-12 11:21 ` Masami Hiramatsu
1 sibling, 0 replies; 3+ messages in thread
From: Masami Hiramatsu @ 2022-10-12 11:21 UTC (permalink / raw)
To: Sven Schnelle
Cc: Steven Rostedt, Ingo Molnar, Shuah Khan,
Masami Hiramatsu (Google), linux-kselftest, linux-kernel
Hi Sven,
2022年10月10日(月) 8:42 Sven Schnelle <svens@linux.ibm.com>:
>
> commit 95c104c378dc ("tracing: Auto generate event name when creating a
> group of events") changed the syntax in the ftrace README file which is
> used by the selftests to check what features are support. Adjust the
> string to make test_duplicates.tc and trigger-synthetic-eprobe.tc work
> again.
>
> Fixes: 95c104c378dc ("tracing: Auto generate event name when creating a group of events")
> Signed-off-by: Sven Schnelle <svens@linux.ibm.com>
Thanks for fixing it!
Acked-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
> ---
> .../testing/selftests/ftrace/test.d/dynevent/test_duplicates.tc | 2 +-
> .../test.d/trigger/inter-event/trigger-synthetic-eprobe.tc | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/testing/selftests/ftrace/test.d/dynevent/test_duplicates.tc b/tools/testing/selftests/ftrace/test.d/dynevent/test_duplicates.tc
> index db522577ff78..d3a79da215c8 100644
> --- a/tools/testing/selftests/ftrace/test.d/dynevent/test_duplicates.tc
> +++ b/tools/testing/selftests/ftrace/test.d/dynevent/test_duplicates.tc
> @@ -1,7 +1,7 @@
> #!/bin/sh
> # SPDX-License-Identifier: GPL-2.0
> # description: Generic dynamic event - check if duplicate events are caught
> -# requires: dynamic_events "e[:[<group>/]<event>] <attached-group>.<attached-event> [<args>]":README
> +# requires: dynamic_events "e[:[<group>/][<event>]] <attached-group>.<attached-event> [<args>]":README
>
> echo 0 > events/enable
>
> diff --git a/tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-synthetic-eprobe.tc b/tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-synthetic-eprobe.tc
> index 914fe2e5d030..6461c375694f 100644
> --- a/tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-synthetic-eprobe.tc
> +++ b/tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-synthetic-eprobe.tc
> @@ -1,7 +1,7 @@
> #!/bin/sh
> # SPDX-License-Identifier: GPL-2.0
> # description: event trigger - test inter-event histogram trigger eprobe on synthetic event
> -# requires: dynamic_events synthetic_events events/syscalls/sys_enter_openat/hist "e[:[<group>/]<event>] <attached-group>.<attached-event> [<args>]":README
> +# requires: dynamic_events synthetic_events events/syscalls/sys_enter_openat/hist "e[:[<group>/][<event>]] <attached-group>.<attached-event> [<args>]":README
>
> echo 0 > events/enable
>
> --
> 2.34.1
>
--
Masami Hiramatsu
mailto:masami.hiramatsu@gmail.com
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-10-12 11:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-10-10 7:42 [PATCH] selftests/ftrace: fix dynamic_events dependency check Sven Schnelle
2022-10-12 11:12 ` Steven Rostedt
2022-10-12 11:21 ` Masami Hiramatsu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox