Re: [PATCH 08/20] phy: qcom-qmp-combo: clean up status polling

Johan Hovold
2022-10-17T06:56:39Z

On Thu, Oct 13, 2022 at 12:14:17AM +0300, Dmitry Baryshkov wrote:
> On 12/10/2022 11:49, Johan Hovold wrote:
> > Clean up the PHY status polling by dropping the configuration mask which
> > is no longer needed since the QMP driver split.
> >
> > Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
>
> This comes in expectation that 4.20 / 5.20 PHYs will be limited to PCIe.
> I'd add this to the commit message.

I don't think that's needed. The commit message is correct as it stands,
and the fact that we may need to change code in case we add support for
new devices that may need it is quite natural.

Also note that the vendor drivers (5.4) only have such a provision for
PCIe PHYs and not for the combo and USB PHY drivers.

> With that fixed:
>
> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>

Johan