From: Kees Cook <keescook@chromium.org>
To: "Guilherme G. Piccoli" <gpiccoli@igalia.com>
Cc: linux-hardening@vger.kernel.org,
Anton Vorontsov <anton@enomsg.org>,
Colin Cross <ccross@android.com>, Tony Luck <tony.luck@intel.com>,
Paramjit Oberoi <pso@chromium.org>,
Ard Biesheuvel <ardb@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/5] pstore/ram: Move internal definitions out of kernel-wide include
Date: Wed, 12 Oct 2022 14:51:52 -0700 [thread overview]
Message-ID: <202210121451.7CEC6637@keescook> (raw)
In-Reply-To: <5fdffa8b-04cb-b42f-e29a-03e9e9045424@igalia.com>
On Wed, Oct 12, 2022 at 04:46:44PM -0300, Guilherme G. Piccoli wrote:
> On 11/10/2022 17:01, Kees Cook wrote:
> > Most of the details of the ram backend are entirely internal to the
> > backend itself. Leave only what is needed to instantiate a ram backend
> > in the kernel-wide header.
> >
> > Cc: Anton Vorontsov <anton@enomsg.org>
> > Cc: Colin Cross <ccross@android.com>
> > Cc: Tony Luck <tony.luck@intel.com>
> > Signed-off-by: Kees Cook <keescook@chromium.org>
> > ---
>
> Reviewed-and-tested-by: Guilherme G. Piccoli <gpiccoli@igalia.com>
>
> Tested by building and booting the kernel - since it's just header file
> rework, guess this is enough right?
>
> BTW, let me know if you prefer me to respond on the series once or per
> patch Kees (as I'm doing here).
Thanks! Yeah, per-patch is good. :)
--
Kees Cook
next prev parent reply other threads:[~2022-10-12 21:52 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-11 20:01 [PATCH 0/5] Move internal definitions out of kernel-wide include Kees Cook
2022-10-11 20:01 ` [PATCH 1/5] pstore/ram: Consolidate kfree() paths Kees Cook
2022-10-12 19:43 ` Guilherme G. Piccoli
2022-10-11 20:01 ` [PATCH 2/5] pstore/ram: Move pmsg init earlier Kees Cook
2022-10-12 19:45 ` Guilherme G. Piccoli
2022-10-11 20:01 ` [PATCH 3/5] pstore/ram: Move internal definitions out of kernel-wide include Kees Cook
2022-10-12 19:46 ` Guilherme G. Piccoli
2022-10-12 21:51 ` Kees Cook [this message]
2022-10-11 20:01 ` [PATCH 4/5] pstore/ram: Set freed addresses to NULL Kees Cook
2022-10-12 19:44 ` Guilherme G. Piccoli
2022-10-11 20:01 ` [PATCH 5/5] MAINTAINERS: Update pstore maintainers Kees Cook
2022-10-11 20:26 ` Colin Cross
2022-10-11 20:35 ` Guilherme G. Piccoli
2022-10-11 22:20 ` Kees Cook
2022-10-12 15:15 ` Guilherme G. Piccoli
2022-11-16 15:42 ` Guilherme G. Piccoli
2022-11-17 22:01 ` Kees Cook
2022-11-17 22:05 ` Guilherme G. Piccoli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202210121451.7CEC6637@keescook \
--to=keescook@chromium.org \
--cc=anton@enomsg.org \
--cc=ardb@kernel.org \
--cc=ccross@android.com \
--cc=gpiccoli@igalia.com \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pso@chromium.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox