From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38820C4332F for ; Wed, 12 Oct 2022 21:52:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229844AbiJLVv7 (ORCPT ); Wed, 12 Oct 2022 17:51:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51364 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229786AbiJLVv4 (ORCPT ); Wed, 12 Oct 2022 17:51:56 -0400 Received: from mail-pj1-x1032.google.com (mail-pj1-x1032.google.com [IPv6:2607:f8b0:4864:20::1032]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5C85A10B77F for ; Wed, 12 Oct 2022 14:51:55 -0700 (PDT) Received: by mail-pj1-x1032.google.com with SMTP id n18-20020a17090ade9200b0020b0012097cso4509858pjv.0 for ; Wed, 12 Oct 2022 14:51:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=MMkdrM8a4Wm6Z/Kl7TEe3cCVNmmhtiA8aE9Kx1e3Q8s=; b=TUYKEN+G95sVztJY5CjEiECyR5GjIYpV5U9p0yjwdSyFEpYttm0RMi6Q0PWvQ6yFdV VRtvgxOp3uI3inCpGH3FOr6FjDyO2f7wwWJPI2kpYt73uTqjtQdh3KmhSMty8BRUfBl0 N7ZuuYgqZ3MUCjC88KjYOmtJqPkmsSvqJyOCA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=MMkdrM8a4Wm6Z/Kl7TEe3cCVNmmhtiA8aE9Kx1e3Q8s=; b=awmynA+RtRenUgHZzm7X6Qkl2Mu7QXAo8KEd6L6aNLYx74JayJ8aPPemcbmcRtUk6M 9PnsN4WuJo5jgGC7BCDdvmbg8cOzGvI72LZlzEInoDahZekr74LGqmYsEHdFyfZwsgIE xhktriTAQIsnZgNoXeakNP3wVcgourQTGGMtEF8a/+1WDWiFNLaOVN6/zLrw8kyr72EA tx2aePGC+qaD2kyNsyCwC3cZDrT3NVR3TbcA0LJGPJvsFvXLnfHvuBhfGBkNYgD1OtdA FM2xBI/dLoZc0m9Ku6OtHewLc79k6fdZ6aT6lS7s5VtMAvCSGyJ0mKsbRUwGRBLoIiHF TyMw== X-Gm-Message-State: ACrzQf0DWwqKJORucM/usO8sepA4QIuB3ggGHSTVoSKEIuf5liDMD4kl goNXSkDeFHlPLsptJejTZMFGUw== X-Google-Smtp-Source: AMsMyM7iuF+bV6cq/p751ThV+63Wb/aSfEUUJyyZL5WMf3GxUkeQYQ2VDnLDDlLfuvl/Y+JZiAAuNg== X-Received: by 2002:a17:90b:1c82:b0:1ee:eb41:b141 with SMTP id oo2-20020a17090b1c8200b001eeeb41b141mr7561080pjb.143.1665611514803; Wed, 12 Oct 2022 14:51:54 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id n19-20020a170903405300b00177e5d83d3dsm11018291pla.170.2022.10.12.14.51.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Oct 2022 14:51:53 -0700 (PDT) Date: Wed, 12 Oct 2022 14:51:52 -0700 From: Kees Cook To: "Guilherme G. Piccoli" Cc: linux-hardening@vger.kernel.org, Anton Vorontsov , Colin Cross , Tony Luck , Paramjit Oberoi , Ard Biesheuvel , linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/5] pstore/ram: Move internal definitions out of kernel-wide include Message-ID: <202210121451.7CEC6637@keescook> References: <20221011200112.731334-1-keescook@chromium.org> <20221011200112.731334-4-keescook@chromium.org> <5fdffa8b-04cb-b42f-e29a-03e9e9045424@igalia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5fdffa8b-04cb-b42f-e29a-03e9e9045424@igalia.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 12, 2022 at 04:46:44PM -0300, Guilherme G. Piccoli wrote: > On 11/10/2022 17:01, Kees Cook wrote: > > Most of the details of the ram backend are entirely internal to the > > backend itself. Leave only what is needed to instantiate a ram backend > > in the kernel-wide header. > > > > Cc: Anton Vorontsov > > Cc: Colin Cross > > Cc: Tony Luck > > Signed-off-by: Kees Cook > > --- > > Reviewed-and-tested-by: Guilherme G. Piccoli > > Tested by building and booting the kernel - since it's just header file > rework, guess this is enough right? > > BTW, let me know if you prefer me to respond on the series once or per > patch Kees (as I'm doing here). Thanks! Yeah, per-patch is good. :) -- Kees Cook