From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73B0EC43217 for ; Thu, 13 Oct 2022 01:37:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229959AbiJMBhr (ORCPT ); Wed, 12 Oct 2022 21:37:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36406 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229681AbiJMBh2 (ORCPT ); Wed, 12 Oct 2022 21:37:28 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0A28814D8FF; Wed, 12 Oct 2022 18:37:26 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 76BCD616EB; Thu, 13 Oct 2022 00:23:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 55025C433D6; Thu, 13 Oct 2022 00:23:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1665620607; bh=Pb1LzrXPC82IIIm7m5LUcYzeme4hYX2EJViSVH+XwQQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ClG1xAsZ5J2jMwjqDvhkbhB0Qq/25tR7y8TVnF+ChiR5it5W9K+aVsGT+Kg6ZW1Iy eu5rjzum9aBgF/4h2saYTMRlqAyK5xF8M13JZQyq9MTGaTewsiJsHH066lOBrXV2R5 /78t1AdNgeoYY9LvTB3MWkyk7/BjAog98bKFsOfjBGSWc5GjvxO0S4mrX9tuSNoXnm ygPRuf8friu5kMyrxrjiILRls8EGQJ0MaEkPVsi2rja/i3hAoiUpkoE/bKoYsNeHYW kULTQ3nzaUZhl2PHwyJKQrrY8ny6JMvDGWYYX4xDlNt0Qvu95YVnVgaIfUsHEQ6eL0 7iUu6TcVYeJMQ== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Maxime Ripard , =?UTF-8?q?Noralf=20Tr=C3=B8nnes?= , Stefan Wahren , Stephen Boyd , Sasha Levin , mturquette@baylibre.com, f.fainelli@gmail.com, rjui@broadcom.com, sbranden@broadcom.com, nsaenz@kernel.org, iivanov@suse.de, linux-clk@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH AUTOSEL 5.15 46/47] clk: bcm2835: Make peripheral PLLC critical Date: Wed, 12 Oct 2022 20:21:21 -0400 Message-Id: <20221013002124.1894077-46-sashal@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20221013002124.1894077-1-sashal@kernel.org> References: <20221013002124.1894077-1-sashal@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Maxime Ripard [ Upstream commit 6c5422851d8be8c7451e968fd2e6da41b6109e17 ] When testing for a series affecting the VEC, it was discovered that turning off and on the VEC clock is crashing the system. It turns out that, when disabling the VEC clock, it's the only child of the PLLC-per clock which will also get disabled. The source of the crash is PLLC-per being disabled. It's likely that some other device might not take a clock reference that it actually needs, but it's unclear which at this point. Let's make PLLC-per critical so that we don't have that crash. Reported-by: Noralf Trønnes Signed-off-by: Maxime Ripard Link: https://lore.kernel.org/r/20220926084509.12233-1-maxime@cerno.tech Reviewed-by: Stefan Wahren Acked-by: Noralf Trønnes Signed-off-by: Stephen Boyd Signed-off-by: Sasha Levin --- drivers/clk/bcm/clk-bcm2835.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clk/bcm/clk-bcm2835.c b/drivers/clk/bcm/clk-bcm2835.c index 3667b4d731e7..298763e78263 100644 --- a/drivers/clk/bcm/clk-bcm2835.c +++ b/drivers/clk/bcm/clk-bcm2835.c @@ -1785,7 +1785,7 @@ static const struct bcm2835_clk_desc clk_desc_array[] = { .load_mask = CM_PLLC_LOADPER, .hold_mask = CM_PLLC_HOLDPER, .fixed_divider = 1, - .flags = CLK_SET_RATE_PARENT), + .flags = CLK_IS_CRITICAL | CLK_SET_RATE_PARENT), /* * PLLD is the display PLL, used to drive DSI display panels. -- 2.35.1