From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7ADBDC433FE for ; Thu, 13 Oct 2022 00:56:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232290AbiJMA4r (ORCPT ); Wed, 12 Oct 2022 20:56:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39452 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230196AbiJMA40 (ORCPT ); Wed, 12 Oct 2022 20:56:26 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5971560521; Wed, 12 Oct 2022 17:53:28 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6F86861705; Thu, 13 Oct 2022 00:27:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 10A68C433D7; Thu, 13 Oct 2022 00:27:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1665620827; bh=boGB8rjtp2E8i0t+l+1UyueK2IRZ7gBv+ZOPOpNj+IA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=buS093y6t7dDCMA4cjInBvk4lWLDRJPoHTB9CB0bgo7jf43YVdYrStlkfPE9pM7Zu OU4OyfLLAPeAJN/DOkdiaWWChz50Vr8dUVqL/Y3HfAtxoUJOD39uf7d4ili1WLq4nV PyFsn4P2kKmAYsYzy2qQNigq4MF7wHYenJeY1xQxoApExD1ecWJMEf3lN8lxOdlFER B5Oao2bKZRxsS0ZSV7Q2MRcJjEiNgHZvDKePTNiej0vXmaGjtfvo3a8CxgfnIFejoT MJYRt4SOpfaxcE/HGAfxb4enzMGPG/LGLYMihlt8M8o9EsOrS7GY1tn5dYKSc/bIml Kj/nL7SRsmHWQ== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Lv Ruyi , Zeal Robot , Joel Stanley , Sasha Levin , jk@ozlabs.org, linux-fsi@lists.ozlabs.org Subject: [PATCH AUTOSEL 4.19 18/19] fsi: master-ast-cf: Fix missing of_node_put in fsi_master_acf_probe Date: Wed, 12 Oct 2022 20:26:17 -0400 Message-Id: <20221013002623.1895576-18-sashal@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20221013002623.1895576-1-sashal@kernel.org> References: <20221013002623.1895576-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Lv Ruyi [ Upstream commit 182d98e00e4745fe253cb0c24c63bbac253464a2 ] of_parse_phandle returns node pointer with refcount incremented, use of_node_put() on it when done. Reported-by: Zeal Robot Signed-off-by: Lv Ruyi Link: https://lore.kernel.org/r/20220407085911.2491719-1-lv.ruyi@zte.com.cn Signed-off-by: Joel Stanley Signed-off-by: Sasha Levin --- drivers/fsi/fsi-master-ast-cf.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/fsi/fsi-master-ast-cf.c b/drivers/fsi/fsi-master-ast-cf.c index 04d10ea8d343..1d39e435bfd1 100644 --- a/drivers/fsi/fsi-master-ast-cf.c +++ b/drivers/fsi/fsi-master-ast-cf.c @@ -1324,12 +1324,14 @@ static int fsi_master_acf_probe(struct platform_device *pdev) } master->cvic = devm_of_iomap(&pdev->dev, np, 0, NULL); if (IS_ERR(master->cvic)) { + of_node_put(np); rc = PTR_ERR(master->cvic); dev_err(&pdev->dev, "Error %d mapping CVIC\n", rc); goto err_free; } rc = of_property_read_u32(np, "copro-sw-interrupts", &master->cvic_sw_irq); + of_node_put(np); if (rc) { dev_err(&pdev->dev, "Can't find coprocessor SW interrupt\n"); goto err_free; -- 2.35.1