From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58425C433FE for ; Thu, 13 Oct 2022 00:36:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231961AbiJMAgH (ORCPT ); Wed, 12 Oct 2022 20:36:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46818 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231708AbiJMAcV (ORCPT ); Wed, 12 Oct 2022 20:32:21 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D02257F136; Wed, 12 Oct 2022 17:28:38 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 59F6EB81CC6; Thu, 13 Oct 2022 00:26:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1B3F4C433C1; Thu, 13 Oct 2022 00:26:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1665620794; bh=OMc2Noxt8vfl1gcPTrZ8XL2sdgJFYQXsLCvRYvKJc0I=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=H0OOrS7nXruDbzMNuqj0aAV6HzaSjCHlqlX9ziXlKDgFWU0R5YLN+dgGU6elblytb 1ux7GQ0nqWGEuN5WE7uBaiLnxNI0tVN9SXvB6jx5b8J6HVZr6BlCY59w4YnD7sBOEa 57Ztfeuv3pRWLeTXnF3u/6aMqkHpsqDfS2G4UNoStoEGYnAkWjsQm7zsEuqwe32fUU rhKBQxzRiFNQAv+dNV3+Ex/KFrMTa+XWELhVpcc3MtiuPnpJI2j+Lpyy7juqdGhAl6 HHWiSacFwYPwJm4o2gc5yiZLmRqhf+oBUW3ndEO1qYsarBhKetK8j17bJjUpROuFq6 GHoTHB4ctXc9w== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Nam Cao , Philipp Hortmann , Greg Kroah-Hartman , Sasha Levin , forest@alittletooquiet.net, tomm.merciai@gmail.com, linux-staging@lists.linux.dev Subject: [PATCH AUTOSEL 4.19 05/19] staging: vt6655: fix potential memory leak Date: Wed, 12 Oct 2022 20:26:04 -0400 Message-Id: <20221013002623.1895576-5-sashal@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20221013002623.1895576-1-sashal@kernel.org> References: <20221013002623.1895576-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Nam Cao [ Upstream commit c8ff91535880d41b49699b3829fb6151942de29e ] In function device_init_td0_ring, memory is allocated for member td_info of priv->apTD0Rings[i], with i increasing from 0. In case of allocation failure, the memory is freed in reversed order, with i decreasing to 0. However, the case i=0 is left out and thus memory is leaked. Modify the memory freeing loop to include the case i=0. Tested-by: Philipp Hortmann Signed-off-by: Nam Cao Link: https://lore.kernel.org/r/20220909141338.19343-1-namcaov@gmail.com Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/staging/vt6655/device_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/vt6655/device_main.c b/drivers/staging/vt6655/device_main.c index 76f434c1c088..0cedb27c052d 100644 --- a/drivers/staging/vt6655/device_main.c +++ b/drivers/staging/vt6655/device_main.c @@ -677,7 +677,7 @@ static int device_init_td0_ring(struct vnt_private *priv) return 0; err_free_desc: - while (--i) { + while (i--) { desc = &priv->apTD0Rings[i]; kfree(desc->td_info); } -- 2.35.1