Re: [PATCH 2/2] Documentation: Add HOWTO Spanish translation into rst based build system

Jonathan Corbet
2022-10-14T14:00:07Z

Carlos Bilbao <carlos.bilbao@amd.com> writes:

> On 10/14/22 04:21, Bagas Sanjaya wrote:
>
>> ¡Hola Carlos! Gracias for start writing Spanish translations. However,
>> the patch can be improved, see below.
> Hola Bagas, thanks for your feedback :)
>>
>> On Thu, Oct 13, 2022 at 01:48:16PM -0500, Carlos Bilbao wrote:
>>> This commit adds Spanish translation of HOWTO document into rst based
>>> documentation build system.
>>>
>> Better say "Translate HOWTO document into Spanish".
> So, for the commit message here I just replicated what prior folks did,
> see:
>
> For Japanese:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/Documentation/translations/ja_JP?h=v6.0&id=f012733894d36ff687862e9cd3b02ee980c61416
>
> For Korean:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/Documentation/translations/ko_KR/howto.rst?h=v6.0&id=ba42c574fc8b803ec206785b7b91325c05810422
>
> I think I will leave that commit message, it is slightly more informative
> than "Translate HOWTO document into Spanish".

Just so you know, the standard advice (as found in submitting-patches.rst)
is to use the imperative mode in changelogs. Some maintainers are quite
insistent that things be done that way. I'm not one of those, though,
so I think the existing message is fine.

Thanks,

jon