From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E77FC43217 for ; Fri, 14 Oct 2022 13:58:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230266AbiJNN6P (ORCPT ); Fri, 14 Oct 2022 09:58:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42928 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229652AbiJNN5c (ORCPT ); Fri, 14 Oct 2022 09:57:32 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E12A71D1A86; Fri, 14 Oct 2022 06:57:15 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id A8206B82215; Fri, 14 Oct 2022 13:54:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 585AAC433B5; Fri, 14 Oct 2022 13:54:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1665755679; bh=9mae/2kNavQataQI+MB9YEXoJv91uSxlXWeWWp7q2K8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=S56tekMO3r8+DBHfm6AX2eDi93bwGaggx3HqJ1W7Kz58p8XDhGbsouA07vZCJ45MI ik4fhfF6CVRJEGg/o/aI8ZAFJDtkelc5H7pZB8RBXcn9DGE4+AdLRBKh/ydlYIHsBD o4AxL10kSqypnoYc1gfjB823O406bUpRJgvl/AgensZ/kt4fgqo4wPDkU3lgJGAHp0 YTPUUNz0k22RhUPwBgfJrex0QYowpRk6BHaljRgJTv1k+rLo9HNEd7/zSaPpkur44C yZIHPEZgfLbkZ39JVowlycpxtNnyjcxhpE9FR1lLBfU3q3MZACX3MbQSoNAZHSmJhg kR4xCESRZcNKQ== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Rohan McLure , Nicholas Piggin , Michael Ellerman , Sasha Levin , christophe.leroy@csgroup.eu, maqianga@uniontech.com, linuxppc-dev@lists.ozlabs.org Subject: [PATCH AUTOSEL 4.19 3/5] powerpc: Remove direct call to personality syscall handler Date: Fri, 14 Oct 2022 09:54:26 -0400 Message-Id: <20221014135430.2110067-3-sashal@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20221014135430.2110067-1-sashal@kernel.org> References: <20221014135430.2110067-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Rohan McLure [ Upstream commit 4df0221f9ded8c39aecfb1a80cef346026671cb7 ] Syscall handlers should not be invoked internally by their symbol names, as these symbols defined by the architecture-defined SYSCALL_DEFINE macro. Fortunately, in the case of ppc64_personality, its call to sys_personality can be replaced with an invocation to the equivalent ksys_personality inline helper in . Signed-off-by: Rohan McLure Reviewed-by: Nicholas Piggin Signed-off-by: Michael Ellerman Link: https://lore.kernel.org/r/20220921065605.1051927-13-rmclure@linux.ibm.com Signed-off-by: Sasha Levin --- arch/powerpc/kernel/syscalls.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/kernel/syscalls.c b/arch/powerpc/kernel/syscalls.c index 466216506eb2..94067b6979e4 100644 --- a/arch/powerpc/kernel/syscalls.c +++ b/arch/powerpc/kernel/syscalls.c @@ -109,7 +109,7 @@ long ppc64_personality(unsigned long personality) if (personality(current->personality) == PER_LINUX32 && personality(personality) == PER_LINUX) personality = (personality & ~PER_MASK) | PER_LINUX32; - ret = sys_personality(personality); + ret = ksys_personality(personality); if (personality(ret) == PER_LINUX32) ret = (ret & ~PER_MASK) | PER_LINUX; return ret; -- 2.35.1