Re: [PATCH v2] clk: mediatek: clk-mux: Add .determine_rate() callback

Stephen Boyd
2022-10-14T19:36:58Z

Quoting Maxime Ripard (2022-10-12 06:56:19)
>
> I think we need to address this in multiple ways:
>
> - If you have ftrace enabled on that platform, running with "tp_printk
> trace_event=clk:*" in the kernel command line on a failing kernel would
> be great, so that we can figure out what is happening exactly.
>
> - We really need to merge your patch above as well;
>
> - And, if we can, we should forbid to register a mux without a
> determine_rate implementation. We have to take into account that some
> muxes are going to be RO and won't need a determine_rate
> implementation at all, but a clock with a set_parent and without a
> determine_rate seems like a weird combination.
>

So should I apply this patch now on clk-next? Given this regression I'm
leaning towards not sending off the clk rate request this merge window
and letting it bake another cycle.