From: David Sterba <dsterba@suse.cz>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: linux-kbuild@vger.kernel.org,
Michal Marek <michal.lkml@markovi.net>,
Nick Desaulniers <ndesaulniers@google.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kbuild: fix single directory build
Date: Fri, 14 Oct 2022 23:18:47 +0200 [thread overview]
Message-ID: <20221014211847.GL13389@suse.cz> (raw)
In-Reply-To: <20221014201811.1118103-1-masahiroy@kernel.org>
On Sat, Oct 15, 2022 at 05:18:11AM +0900, Masahiro Yamada wrote:
> Commit f110e5a250e3 ("kbuild: refactor single builds of *.ko") was wrong.
>
> KBUILD_MODULES _is_ needed for single builds.
>
> Otherwise, "make foo/bar/baz/" does not build module objects at all.
>
> Fixes: f110e5a250e3 ("kbuild: refactor single builds of *.ko")
> Reported-by: David Sterba <dsterba@suse.cz>
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Now it works, thanks.
Tested-by: David Sterba <dsterba@suse.com>
prev parent reply other threads:[~2022-10-14 21:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-14 20:18 [PATCH] kbuild: fix single directory build Masahiro Yamada
2022-10-14 21:18 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221014211847.GL13389@suse.cz \
--to=dsterba@suse.cz \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=michal.lkml@markovi.net \
--cc=ndesaulniers@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox