From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D71A4C4332F for ; Mon, 17 Oct 2022 06:10:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230128AbiJQGKA (ORCPT ); Mon, 17 Oct 2022 02:10:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36432 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229616AbiJQGJ5 (ORCPT ); Mon, 17 Oct 2022 02:09:57 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 233212A961; Sun, 16 Oct 2022 23:09:54 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id 665D168BFE; Mon, 17 Oct 2022 08:09:51 +0200 (CEST) Date: Mon, 17 Oct 2022 08:09:51 +0200 From: Christoph Hellwig To: Christoph =?iso-8859-1?Q?B=F6hmwalder?= Cc: Jens Axboe , Philipp Reisner , drbd-dev@lists.linbit.com, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Christoph Hellwig , Joel Colledge Subject: Re: [PATCH] drbd: only clone bio if we have a backing device Message-ID: <20221017060951.GA28409@lst.de> References: <20221013135352.933875-1-christoph.boehmwalder@linbit.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20221013135352.933875-1-christoph.boehmwalder@linbit.com> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 13, 2022 at 03:53:52PM +0200, Christoph Böhmwalder wrote: > + if (get_ldev(device)) { > + req->private_bio = bio_alloc_clone(device->ldev->backing_bdev, > + bio, GFP_NOIO, &drbd_io_bio_set); This adds an overly long line. Otherwise looks good: Reviewed-by: Christoph Hellwig