* [PATCH] nvme-pci: disable write zeroes on Kingston SSD
@ 2022-10-11 11:06 Xander Li
2022-10-16 5:14 ` Chaitanya Kulkarni
2022-10-17 7:20 ` Christoph Hellwig
0 siblings, 2 replies; 4+ messages in thread
From: Xander Li @ 2022-10-11 11:06 UTC (permalink / raw)
To: bvanassche, paulburton, kbusch, axboe, hch, sagi, linux-nvme,
linux-kernel
Cc: ralf, jhogan, christian, jeff_yang, dora_chueh, james_liu,
vincent_wu, xander_li, Xander Li
signed-off-by: Xander Li <xander_li@kingston.com.tw>
Kingston SSDs do support NVMe Write_Zeroes cmd but take long time to process.
The firmware version is locked by these SSDs, we can not expect firmware improvement, so disable Write_Zeroes cmd.
---
drivers/nvme/host/pci.c | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
index 98864b853eef..d08c8c854f3a 100644
--- a/drivers/nvme/host/pci.c
+++ b/drivers/nvme/host/pci.c
@@ -3503,6 +3503,16 @@ static const struct pci_device_id nvme_id_table[] = {
.driver_data = NVME_QUIRK_NO_DEEPEST_PS, },
{ PCI_DEVICE(0x2646, 0x2263), /* KINGSTON A2000 NVMe SSD */
.driver_data = NVME_QUIRK_NO_DEEPEST_PS, },
+ { PCI_DEVICE(0x2646, 0x5018), /* KINGSTON OM8SFP4xxxxP OS21012 NVMe SSD */
+ .driver_data = NVME_QUIRK_DISABLE_WRITE_ZEROES, },
+ { PCI_DEVICE(0x2646, 0x5016), /* KINGSTON OM3PGP4xxxxP OS21011 NVMe SSD */
+ .driver_data = NVME_QUIRK_DISABLE_WRITE_ZEROES, },
+ { PCI_DEVICE(0x2646, 0x501A), /* KINGSTON OM8PGP4xxxxP OS21005 NVMe SSD */
+ .driver_data = NVME_QUIRK_DISABLE_WRITE_ZEROES, },
+ { PCI_DEVICE(0x2646, 0x501B), /* KINGSTON OM8PGP4xxxxQ OS21005 NVMe SSD */
+ .driver_data = NVME_QUIRK_DISABLE_WRITE_ZEROES, },
+ { PCI_DEVICE(0x2646, 0x501E), /* KINGSTON OM3PGP4xxxxQ OS21011 NVMe SSD */
+ .driver_data = NVME_QUIRK_DISABLE_WRITE_ZEROES, },
{ PCI_DEVICE(0x1e4B, 0x1001), /* MAXIO MAP1001 */
.driver_data = NVME_QUIRK_BOGUS_NID, },
{ PCI_DEVICE(0x1e4B, 0x1002), /* MAXIO MAP1002 */
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] nvme-pci: disable write zeroes on Kingston SSD
2022-10-11 11:06 [PATCH] nvme-pci: disable write zeroes on Kingston SSD Xander Li
@ 2022-10-16 5:14 ` Chaitanya Kulkarni
2022-10-17 7:20 ` Christoph Hellwig
1 sibling, 0 replies; 4+ messages in thread
From: Chaitanya Kulkarni @ 2022-10-16 5:14 UTC (permalink / raw)
To: Xander Li, bvanassche@acm.org, paulburton@kernel.org,
kbusch@kernel.org, axboe@fb.com, hch@lst.de, sagi@grimberg.me,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org
Cc: ralf@linux-mips.org, jhogan@kernel.org, christian@brauner.io,
jeff_yang@kingston.corp-partner.google.com,
dora_chueh@kingston.corp-partner.google.com,
james_liu@kingston.corp-partner.google.com,
vincent_wu@kingston.com, xander_li@kingston.com.tw
On 10/11/22 04:06, Xander Li wrote:
> signed-off-by: Xander Li <xander_li@kingston.com.tw>
>
> Kingston SSDs do support NVMe Write_Zeroes cmd but take long time to process.
> The firmware version is locked by these SSDs, we can not expect firmware improvement, so disable Write_Zeroes cmd.
plz fix overly long line(s) in the commit message.
-ck
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] nvme-pci: disable write zeroes on Kingston SSD
2022-10-11 11:06 [PATCH] nvme-pci: disable write zeroes on Kingston SSD Xander Li
2022-10-16 5:14 ` Chaitanya Kulkarni
@ 2022-10-17 7:20 ` Christoph Hellwig
1 sibling, 0 replies; 4+ messages in thread
From: Christoph Hellwig @ 2022-10-17 7:20 UTC (permalink / raw)
To: Xander Li
Cc: bvanassche, paulburton, kbusch, axboe, hch, sagi, linux-nvme,
linux-kernel, ralf, jhogan, christian, jeff_yang, dora_chueh,
james_liu, vincent_wu, xander_li
Thanks,
applied with a fixed up commit log.
^ permalink raw reply [flat|nested] 4+ messages in thread
[parent not found: <CO1PR10MB4691DEAA88F86F001ACA5A1CCB5D9@CO1PR10MB4691.namprd10.prod.outlook.com>]
* Re: [patch] nvme-pci: disable Write_Zeroes on Kingston SSD
[not found] <CO1PR10MB4691DEAA88F86F001ACA5A1CCB5D9@CO1PR10MB4691.namprd10.prod.outlook.com>
@ 2022-10-10 8:20 ` hch
0 siblings, 0 replies; 4+ messages in thread
From: hch @ 2022-10-10 8:20 UTC (permalink / raw)
To: Xander Li
Cc: Bart Van Assche, paulburton@kernel.org, kbusch@kernel.org,
axboe@fb.com, hch@lst.de, sagi@grimberg.me,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
ralf@linux-mips.org, jhogan@kernel.org, christian@brauner.io,
jeff_yang@kingston.corp-partner.google.com,
dora_chueh@kingston.corp-partner.google.com,
james_liu@kingston.corp-partner.google.com, Vincent Wu
On Wed, Oct 05, 2022 at 10:01:11AM +0000, Xander Li wrote:
>
> drivers/nvme/host/pci.c | 10 ++++++++++
>
> 1 file changed, 10 insertions(+)
>
>
>
> diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
>
> index 98864b853eef..d08c8c854f3a 100644
>
> --- a/drivers/nvme/host/pci.c
>
> +++ b/drivers/nvme/host/pci.c
This patch seems very white space damaged.
>
> @@ -3503,6 +3503,16 @@ static const struct pci_device_id nvme_id_table[] = {
>
> .driver_data = NVME_QUIRK_NO_DEEPEST_PS, },
>
> { PCI_DEVICE(0x2646, 0x2263), /* KINGSTON A2000 NVMe SSD */
>
> .driver_data = NVME_QUIRK_NO_DEEPEST_PS, },
>
> + { PCI_DEVICE(0x2646, 0x5018), /* KINGSTON OM8SFP4xxxxP OS21012 NVMe SSD */
>
> + .driver_data = NVME_QUIRK_DISABLE_WRITE_ZEROES, },
>
> + { PCI_DEVICE(0x2646, 0x5016), /* KINGSTON OM3PGP4xxxxP OS21011 NVMe SSD */
>
> + .driver_data = NVME_QUIRK_DISABLE_WRITE_ZEROES, },
>
> + { PCI_DEVICE(0x2646, 0x501A), /* KINGSTON OM8PGP4xxxxP OS21005 NVMe SSD */
>
> + .driver_data = NVME_QUIRK_DISABLE_WRITE_ZEROES, },
>
> + { PCI_DEVICE(0x2646, 0x501B), /* KINGSTON OM8PGP4xxxxQ OS21005 NVMe SSD */
>
> + .driver_data = NVME_QUIRK_DISABLE_WRITE_ZEROES, },
>
> + { PCI_DEVICE(0x2646, 0x501E), /* KINGSTON OM3PGP4xxxxQ OS21011 NVMe SSD */
>
> + .driver_data = NVME_QUIRK_DISABLE_WRITE_ZEROES, },
>
> { PCI_DEVICE(0x1e4B, 0x1001), /* MAXIO MAP1001 */
>
> .driver_data = NVME_QUIRK_BOGUS_NID, },
>
> { PCI_DEVICE(0x1e4B, 0x1002), /* MAXIO MAP1002 */
>
> --
>
> 2.25.1
>
>
>
>
>
>
> Xander Li
> Technical Resources Group
> Kingston Technology Far East Corp.
> Office Line: +886-3-5641539 Ext.6135
> E-mail: xander_li@kingston.com.tw<mailto:xander_li@kingston.com.tw>
>
> This email and attachment(s) may contain material that is confidential, privileged and/or attorney work product for the sole use of the intended recipient. Any review, reliance or distribution by others or forwarding without express permission is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.
---end quoted text---
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-10-17 7:20 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-10-11 11:06 [PATCH] nvme-pci: disable write zeroes on Kingston SSD Xander Li
2022-10-16 5:14 ` Chaitanya Kulkarni
2022-10-17 7:20 ` Christoph Hellwig
[not found] <CO1PR10MB4691DEAA88F86F001ACA5A1CCB5D9@CO1PR10MB4691.namprd10.prod.outlook.com>
2022-10-10 8:20 ` [patch] nvme-pci: disable Write_Zeroes " hch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox