public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andrew Davis <afd@ti.com>
To: Nishanth Menon <nm@ti.com>, Vignesh Raghavendra <vigneshr@ti.com>,
	Tero Kristo <kristo@kernel.org>, Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Cc: Andrew Davis <afd@ti.com>
Subject: [PATCH 08/10] arm64: dts: ti: k3-am64: Enable MDIO nodes at the board level
Date: Mon, 17 Oct 2022 14:25:30 -0500	[thread overview]
Message-ID: <20221017192532.23825-9-afd@ti.com> (raw)
In-Reply-To: <20221017192532.23825-1-afd@ti.com>

MDIO nodes defined in the top-level AM64x SoC dtsi files are incomplete
and will not be functional unless they are extended with a pinmux.

As the attached PHY is only known about at the board integration level,
these nodes should only be enabled when provided with this information.

Disable the MDIO nodes (in both CPSW and ICSSG) in the dtsi files and
only enable the ones that are actually pinned out on a given board.

Signed-off-by: Andrew Davis <afd@ti.com>
---
 arch/arm64/boot/dts/ti/k3-am64-main.dtsi | 3 +++
 arch/arm64/boot/dts/ti/k3-am642-evm.dts  | 9 +--------
 arch/arm64/boot/dts/ti/k3-am642-sk.dts   | 9 +--------
 3 files changed, 5 insertions(+), 16 deletions(-)

diff --git a/arch/arm64/boot/dts/ti/k3-am64-main.dtsi b/arch/arm64/boot/dts/ti/k3-am64-main.dtsi
index b193f88a7a0f..7ea07f7fe5a2 100644
--- a/arch/arm64/boot/dts/ti/k3-am64-main.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-am64-main.dtsi
@@ -552,6 +552,7 @@ cpsw3g_mdio: mdio@f00 {
 			clocks = <&k3_clks 13 0>;
 			clock-names = "fck";
 			bus_freq = <1000000>;
+			status = "disabled";
 		};
 
 		cpts@3d000 {
@@ -1168,6 +1169,7 @@ icssg0_mdio: mdio@32400 {
 			#address-cells = <1>;
 			#size-cells = <0>;
 			bus_freq = <1000000>;
+			status = "disabled";
 		};
 	};
 
@@ -1308,6 +1310,7 @@ icssg1_mdio: mdio@32400 {
 			clocks = <&k3_clks 82 0>;
 			clock-names = "fck";
 			bus_freq = <1000000>;
+			status = "disabled";
 		};
 	};
 
diff --git a/arch/arm64/boot/dts/ti/k3-am642-evm.dts b/arch/arm64/boot/dts/ti/k3-am642-evm.dts
index 2319ba4f5ae3..9a3bf852810c 100644
--- a/arch/arm64/boot/dts/ti/k3-am642-evm.dts
+++ b/arch/arm64/boot/dts/ti/k3-am642-evm.dts
@@ -440,6 +440,7 @@ &cpsw_port2 {
 };
 
 &cpsw3g_mdio {
+	status = "okay";
 	pinctrl-names = "default";
 	pinctrl-0 = <&mdio1_pins_default>;
 
@@ -575,14 +576,6 @@ &ecap0 {
 	pinctrl-0 = <&main_ecap0_pins_default>;
 };
 
-&icssg0_mdio {
-	status = "disabled";
-};
-
-&icssg1_mdio {
-	status = "disabled";
-};
-
 &main_mcan0 {
 	pinctrl-names = "default";
 	pinctrl-0 = <&main_mcan0_pins_default>;
diff --git a/arch/arm64/boot/dts/ti/k3-am642-sk.dts b/arch/arm64/boot/dts/ti/k3-am642-sk.dts
index c1d634647027..451e1483f3e4 100644
--- a/arch/arm64/boot/dts/ti/k3-am642-sk.dts
+++ b/arch/arm64/boot/dts/ti/k3-am642-sk.dts
@@ -454,6 +454,7 @@ &cpsw_port2 {
 };
 
 &cpsw3g_mdio {
+	status = "okay";
 	pinctrl-names = "default";
 	pinctrl-0 = <&mdio1_pins_default>;
 
@@ -566,14 +567,6 @@ &ecap0 {
 	pinctrl-0 = <&main_ecap0_pins_default>;
 };
 
-&icssg0_mdio {
-	status = "disabled";
-};
-
-&icssg1_mdio {
-	status = "disabled";
-};
-
 &main_mcan0 {
 	status = "disabled";
 };
-- 
2.37.3


  parent reply	other threads:[~2022-10-17 19:26 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-17 19:25 [PATCH 00/10] AM64x Disable Incomplete DT Nodes Andrew Davis
2022-10-17 19:25 ` [PATCH 01/10] arm64: dts: ti: k3-am64: Enable UART nodes at the board level Andrew Davis
2022-10-17 19:25 ` [PATCH 02/10] arm64: dts: ti: k3-am64: Enable I2C " Andrew Davis
2022-10-17 19:25 ` [PATCH 03/10] arm64: dts: ti: k3-am64: Enable SPI " Andrew Davis
2022-10-17 19:25 ` [PATCH 04/10] arm64: dts: ti: k3-am64: Enable EPWM " Andrew Davis
2022-10-17 19:25 ` [PATCH 05/10] arm64: dts: ti: k3-am64: Enable ECAP " Andrew Davis
2022-10-17 19:25 ` [PATCH 06/10] arm64: dts: ti: k3-am64: Enable PCIe " Andrew Davis
2022-10-17 19:25 ` [PATCH 07/10] arm64: dts: ti: k3-am64: MDIO pinmux should belong to the MDIO node Andrew Davis
2022-10-17 19:25 ` Andrew Davis [this message]
2022-10-17 19:25 ` [PATCH 09/10] arm64: dts: ti: k3-am64: Enable MCAN nodes at the board level Andrew Davis
2022-10-17 19:25 ` [PATCH 10/10] arm64: dts: ti: k3-am64: Enable GPMC and ELM " Andrew Davis
2022-10-18 15:24 ` [PATCH 00/10] AM64x Disable Incomplete DT Nodes Bryan Brattlof
2022-10-27  6:33 ` Vignesh Raghavendra
2022-10-28 13:30 ` Nishanth Menon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221017192532.23825-9-afd@ti.com \
    --to=afd@ti.com \
    --cc=devicetree@vger.kernel.org \
    --cc=kristo@kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nm@ti.com \
    --cc=robh+dt@kernel.org \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox