Re: [PATCH 00/10] AM64x Disable Incomplete DT Nodes

Bryan Brattlof
2022-10-18T15:24:40Z

On October 17, 2022 thus sayeth Andrew Davis:
> Hello all,
>
> This series goes through the AM64x dtsi and disables the set of nodes
> that are not functional without additional board level information.
> This is usually pinmux data, but can also be inernal device resources.
>
> Only when the node is completed in the board file should the node be
> enabled. This helps prevents nodes that represent IP that are not
> pinned-out on a given board from being left enabled.
>
> This also reduces the effort needed to add a new board, one no longer
> needs to manually disable all the extra IP. For instance TI J784s4 has
> 20(!) MCAN instances. It is much easier to enable the one you pin out,
> vs disabling the 19 that you did not.
>
> Thanks,
> Andrew
>
> Andrew Davis (10):
> arm64: dts: ti: k3-am64: Enable UART nodes at the board level
> arm64: dts: ti: k3-am64: Enable I2C nodes at the board level
> arm64: dts: ti: k3-am64: Enable SPI nodes at the board level
> arm64: dts: ti: k3-am64: Enable EPWM nodes at the board level
> arm64: dts: ti: k3-am64: Enable ECAP nodes at the board level
> arm64: dts: ti: k3-am64: Enable PCIe nodes at the board level
> arm64: dts: ti: k3-am64: MDIO pinmux should belong to the MDIO node
> arm64: dts: ti: k3-am64: Enable MDIO nodes at the board level
> arm64: dts: ti: k3-am64: Enable MCAN nodes at the board level
> arm64: dts: ti: k3-am64: Enable GPMC and ELM nodes at the board level
>
> arch/arm64/boot/dts/ti/k3-am64-main.dtsi | 37 ++++++
> arch/arm64/boot/dts/ti/k3-am64-mcu.dtsi | 6 +
> arch/arm64/boot/dts/ti/k3-am642-evm.dts | 119 ++-----------------
> arch/arm64/boot/dts/ti/k3-am642-sk.dts | 142 ++---------------------
> 4 files changed, 63 insertions(+), 241 deletions(-)
>

Reviewed-by: Bryan Brattlof <bb@ti.com>

I wholeheartedly agree! This looks great to me!

~Bryan