From: SeongJae Park <sj@kernel.org>
To: Namhyung Kim <namhyung@kernel.org>
Cc: SeongJae Park <sj@kernel.org>,
Sumanth Korikkar <sumanthk@linux.ibm.com>,
olsajiri@gmail.com, bpf@vger.kernel.org, gor@linux.ibm.com,
hca@linux.ibm.com, iii@linux.ibm.com,
linux-kernel@vger.kernel.org, linux-tip-commits@vger.kernel.org,
peterz@infradead.org, svens@linux.ibm.com,
tip-bot2@linutronix.de, tmricht@linux.ibm.com, x86@kernel.org
Subject: Re: [PATCH] bpf: fix sample_flags for bpf_perf_event_output
Date: Mon, 17 Oct 2022 23:35:44 +0000 [thread overview]
Message-ID: <20221017233544.1408-1-sj@kernel.org> (raw)
In-Reply-To: <CAM9d7cj1cvg6JUp33qxew59qz1_4hEu8noa-E3oO9DXFHabGaw@mail.gmail.com>
On Mon, 17 Oct 2022 15:52:15 -0700 Namhyung Kim <namhyung@kernel.org> wrote:
> Hi SeongJae,
>
> On Mon, Oct 17, 2022 at 12:27 PM SeongJae Park <sj@kernel.org> wrote:
> >
> > Hello,
> >
> >
> > The commit that this patch is fixing[1] also causes yet another segfault for
> > 'perf-script' of tracepoint records. For example:
> >
> > $ sudo timeout 3 perf record -e exceptions:page_fault_user
> > [ perf record: Woken up 1 times to write data ]
> > [ perf record: Captured and wrote 0.228 MB perf.data (74 samples) ]
> > $ sudo perf script
> > Segmentation fault
> >
> > Reverting this patch and the original bug commit[1] fixes the issue. I haven't
> > deep dive yet because I'm not familiar with this area. Anybody has any idea
> > about this?
> >
> > [1] 838d9bb62d13 ("perf: Use sample_flags for raw_data")
>
> Sorry for the trouble.
No problem.
> I think you also need to apply the below:
>
> https://lore.kernel.org/r/20221012143857.48198-1-james.clark@arm.com
Thank you for this nice answer. I confirmed that this fixes my issue.
Thanks,
SJ
[...]
next prev parent reply other threads:[~2022-10-17 23:36 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-21 22:00 [PATCH 1/2] perf: Use sample_flags for addr Namhyung Kim
2022-09-21 22:00 ` [PATCH 2/2] perf: Use sample_flags for raw_data Namhyung Kim
2022-09-28 6:57 ` [tip: perf/core] " tip-bot2 for Namhyung Kim
2022-10-06 16:00 ` [PATCH] " Sumanth Korikkar
2022-10-06 17:12 ` Namhyung Kim
2022-10-06 18:58 ` Jiri Olsa
2022-10-07 8:13 ` [PATCH] bpf: fix sample_flags for bpf_perf_event_output Sumanth Korikkar
2022-10-07 9:45 ` Jiri Olsa
2022-10-07 15:18 ` Peter Zijlstra
2022-10-19 4:57 ` Alexei Starovoitov
2022-10-21 1:36 ` Alexei Starovoitov
2022-10-23 1:16 ` bpf+perf is still broken. Was: " Alexei Starovoitov
2022-10-23 16:55 ` Linus Torvalds
2022-10-23 17:19 ` Linus Torvalds
2022-10-23 17:28 ` Alexei Starovoitov
2022-10-17 14:45 ` [tip: perf/urgent] bpf: Fix " tip-bot2 for Sumanth Korikkar
2022-10-17 19:27 ` [PATCH] bpf: fix " SeongJae Park
2022-10-17 22:52 ` Namhyung Kim
2022-10-17 23:35 ` SeongJae Park [this message]
2022-10-19 10:44 ` [tip: perf/core] perf: Use sample_flags for raw_data Athira Rajeev
2022-09-22 14:48 ` [PATCH 1/2] perf: Use sample_flags for addr Peter Zijlstra
2022-09-22 16:32 ` Namhyung Kim
2022-09-22 20:55 ` [PATCH] perf: Change the layout of perf_sample_data Namhyung Kim
2022-09-23 7:45 ` [PATCH 1/2] perf: Use sample_flags for addr Peter Zijlstra
2022-09-28 6:57 ` [tip: perf/core] " tip-bot2 for Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221017233544.1408-1-sj@kernel.org \
--to=sj@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=iii@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=namhyung@kernel.org \
--cc=olsajiri@gmail.com \
--cc=peterz@infradead.org \
--cc=sumanthk@linux.ibm.com \
--cc=svens@linux.ibm.com \
--cc=tip-bot2@linutronix.de \
--cc=tmricht@linux.ibm.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox