public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
	Rob Herring <robh@kernel.org>, Sasha Levin <sashal@kernel.org>,
	masahiroy@kernel.org, michal.lkml@markovi.net,
	linux-kbuild@vger.kernel.org
Subject: [PATCH AUTOSEL 6.0 17/32] kbuild: take into account DT_SCHEMA_FILES changes while checking dtbs
Date: Mon, 17 Oct 2022 20:07:14 -0400	[thread overview]
Message-ID: <20221018000729.2730519-17-sashal@kernel.org> (raw)
In-Reply-To: <20221018000729.2730519-1-sashal@kernel.org>

From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>

[ Upstream commit d7c6ea024c08bbdb799768f51ffd9fdd6236d190 ]

It is useful to be able to recheck dtbs files against a limited set of
DT schema files. This can be accomplished by using differnt
DT_SCHEMA_FILES argument values while rerunning make dtbs_check. However
for some reason if_changed_rule doesn't pick up the rule_dtc changes
(and doesn't retrigger the build).

Fix this by changing if_changed_rule to if_changed_dep and squashing DTC
and dt-validate into a single new command. Then if_changed_dep triggers
on DT_SCHEMA_FILES changes and reruns the build/check.

Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Link: https://lore.kernel.org/r/20220915114422.79378-1-dmitry.baryshkov@linaro.org
Signed-off-by: Rob Herring <robh@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
 scripts/Makefile.lib | 14 ++++++--------
 1 file changed, 6 insertions(+), 8 deletions(-)

diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib
index 3fb6a99e78c4..cec0560f6ac6 100644
--- a/scripts/Makefile.lib
+++ b/scripts/Makefile.lib
@@ -371,17 +371,15 @@ DT_CHECKER_FLAGS ?= $(if $(DT_SCHEMA_FILES),-l $(DT_SCHEMA_FILES),-m)
 DT_BINDING_DIR := Documentation/devicetree/bindings
 DT_TMP_SCHEMA := $(objtree)/$(DT_BINDING_DIR)/processed-schema.json
 
-quiet_cmd_dtb_check =	CHECK   $@
-      cmd_dtb_check =	$(DT_CHECKER) $(DT_CHECKER_FLAGS) -u $(srctree)/$(DT_BINDING_DIR) -p $(DT_TMP_SCHEMA) $@ || true
+quiet_cmd_dtb =	DTC_CHK $@
+      cmd_dtb =	$(cmd_dtc) ; $(DT_CHECKER) $(DT_CHECKER_FLAGS) -u $(srctree)/$(DT_BINDING_DIR) -p $(DT_TMP_SCHEMA) $@ || true
+else
+quiet_cmd_dtb = $(quiet_cmd_dtc)
+      cmd_dtb = $(cmd_dtc)
 endif
 
-define rule_dtc
-	$(call cmd_and_fixdep,dtc)
-	$(call cmd,dtb_check)
-endef
-
 $(obj)/%.dtb: $(src)/%.dts $(DTC) $(DT_TMP_SCHEMA) FORCE
-	$(call if_changed_rule,dtc)
+	$(call if_changed_dep,dtb)
 
 $(obj)/%.dtbo: $(src)/%.dts $(DTC) FORCE
 	$(call if_changed_dep,dtc)
-- 
2.35.1


  parent reply	other threads:[~2022-10-18  0:09 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-18  0:06 [PATCH AUTOSEL 6.0 01/32] crypto: qcom-rng - Fix qcom_rng_of_match unused warning Sasha Levin
2022-10-18  0:06 ` [PATCH AUTOSEL 6.0 02/32] crypto: ccp - Add a quirk to firmware update Sasha Levin
2022-10-18  0:07 ` [PATCH AUTOSEL 6.0 03/32] crypto: ccp - Initialize PSP when reading psp data file failed Sasha Levin
2022-10-18  0:07 ` [PATCH AUTOSEL 6.0 04/32] gfs2: Switch from strlcpy to strscpy Sasha Levin
2022-10-18  0:07 ` [PATCH AUTOSEL 6.0 05/32] powerpc/hw_breakpoint: Avoid relying on caller synchronization Sasha Levin
2022-10-18  0:07 ` [PATCH AUTOSEL 6.0 06/32] cgroup: Remove data-race around cgrp_dfl_visible Sasha Levin
2022-10-18  0:07 ` [PATCH AUTOSEL 6.0 07/32] iommu/vt-d: Handle race between registration and device probe Sasha Levin
2022-10-18  0:07 ` [PATCH AUTOSEL 6.0 08/32] of/fdt: Don't calculate initrd size from DT if start > end Sasha Levin
2022-10-18  0:07 ` [PATCH AUTOSEL 6.0 09/32] tools/vm/page_owner_sort: fix -f option Sasha Levin
2022-10-18  0:07 ` [PATCH AUTOSEL 6.0 10/32] objtool,x86: Teach decode about LOOP* instructions Sasha Levin
2022-10-18  0:07 ` [PATCH AUTOSEL 6.0 11/32] locking/rwsem: Disable preemption while trying for rwsem lock Sasha Levin
2022-10-18  0:07 ` [PATCH AUTOSEL 6.0 12/32] swiotlb: don't panic! Sasha Levin
2022-10-18  0:07 ` [PATCH AUTOSEL 6.0 13/32] gfs2: Check sb_bsize_shift after reading superblock Sasha Levin
2022-10-18  0:07 ` [PATCH AUTOSEL 6.0 14/32] powerpc/64: don't refer nr_cpu_ids in asm code when it's undefined Sasha Levin
2022-10-18  0:07 ` [PATCH AUTOSEL 6.0 15/32] m68knommu: fix non-specific 68328 choice interrupt build failure Sasha Levin
2022-10-18  0:07 ` [PATCH AUTOSEL 6.0 16/32] m68knommu: fix non-mmu classic 68000 legacy timer tick selection Sasha Levin
2022-10-18  0:07 ` Sasha Levin [this message]
2022-10-18  0:07 ` [PATCH AUTOSEL 6.0 18/32] tracing/user_events: Use WRITE instead of READ for io vector import Sasha Levin
2022-10-18  0:07 ` [PATCH AUTOSEL 6.0 19/32] tracing/user_events: Ensure user provided strings are safely formatted Sasha Levin
2022-10-18  0:07 ` [PATCH AUTOSEL 6.0 20/32] of: Fix "dma-ranges" handling for bus controllers Sasha Levin
2022-10-18  0:07 ` [PATCH AUTOSEL 6.0 21/32] x86/hyperv: Replace kmap() with kmap_local_page() Sasha Levin
2022-10-18  0:07 ` [PATCH AUTOSEL 6.0 22/32] kmsan: disable instrumentation of unsupported common kernel code Sasha Levin
2022-10-18  1:00   ` Marco Elver
2022-10-18  0:07 ` [PATCH AUTOSEL 6.0 23/32] kmsan: disable physical page merging in biovec Sasha Levin
2022-10-18  0:07 ` [PATCH AUTOSEL 6.0 24/32] f2fs: fix wrong dirty page count when race between mmap and fallocate Sasha Levin
2022-10-18  0:07 ` [PATCH AUTOSEL 6.0 25/32] f2fs: code clean and fix a type error Sasha Levin
2022-10-18  0:07 ` [PATCH AUTOSEL 6.0 26/32] f2fs: fix to detect corrupted meta ino Sasha Levin
2022-10-18  0:07 ` [PATCH AUTOSEL 6.0 27/32] 9p: trans_fd/p9_conn_cancel: drop client lock earlier Sasha Levin
2022-10-18  0:07 ` [PATCH AUTOSEL 6.0 28/32] nfsd: fix nfsd_file_unhash_and_dispose Sasha Levin
2022-10-18  0:07 ` [PATCH AUTOSEL 6.0 29/32] 9p/trans_fd: always use O_NONBLOCK read/write Sasha Levin
2022-10-18  0:07 ` [PATCH AUTOSEL 6.0 30/32] net/9p: use a dedicated spinlock for trans_fd Sasha Levin
2022-10-18  0:07 ` [PATCH AUTOSEL 6.0 31/32] virtio_pci: don't try to use intxif pin is zero Sasha Levin
2022-10-18  0:07 ` [PATCH AUTOSEL 6.0 32/32] cifs: replace kfree() with kfree_sensitive() for sensitive data Sasha Levin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221018000729.2730519-17-sashal@kernel.org \
    --to=sashal@kernel.org \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=masahiroy@kernel.org \
    --cc=michal.lkml@markovi.net \
    --cc=robh@kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox