public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: Beau Belgrave <beaub@linux.microsoft.com>,
	Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	Sasha Levin <sashal@kernel.org>,
	mingo@redhat.com
Subject: [PATCH AUTOSEL 6.0 18/32] tracing/user_events: Use WRITE instead of READ for io vector import
Date: Mon, 17 Oct 2022 20:07:15 -0400	[thread overview]
Message-ID: <20221018000729.2730519-18-sashal@kernel.org> (raw)
In-Reply-To: <20221018000729.2730519-1-sashal@kernel.org>

From: Beau Belgrave <beaub@linux.microsoft.com>

[ Upstream commit 95f187603dbff69bef19b2ab3bb54d2c060f556d ]

import_single_range expects the direction/rw to be where it came from,
not the protection/limit. Since the import is in a write path use WRITE.

Link: https://lkml.kernel.org/r/20220728233309.1896-3-beaub@linux.microsoft.com
Link: https://lore.kernel.org/all/2059213643.196683.1648499088753.JavaMail.zimbra@efficios.com/

Reported-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Beau Belgrave <beaub@linux.microsoft.com>
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
 kernel/trace/trace_events_user.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/kernel/trace/trace_events_user.c b/kernel/trace/trace_events_user.c
index a6621c52ce45..b137e1866fbc 100644
--- a/kernel/trace/trace_events_user.c
+++ b/kernel/trace/trace_events_user.c
@@ -1245,7 +1245,8 @@ static ssize_t user_events_write(struct file *file, const char __user *ubuf,
 	if (unlikely(*ppos != 0))
 		return -EFAULT;
 
-	if (unlikely(import_single_range(READ, (char *)ubuf, count, &iov, &i)))
+	if (unlikely(import_single_range(WRITE, (char __user *)ubuf,
+					 count, &iov, &i)))
 		return -EFAULT;
 
 	return user_events_write_core(file, &i);
-- 
2.35.1


  parent reply	other threads:[~2022-10-18  0:10 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-18  0:06 [PATCH AUTOSEL 6.0 01/32] crypto: qcom-rng - Fix qcom_rng_of_match unused warning Sasha Levin
2022-10-18  0:06 ` [PATCH AUTOSEL 6.0 02/32] crypto: ccp - Add a quirk to firmware update Sasha Levin
2022-10-18  0:07 ` [PATCH AUTOSEL 6.0 03/32] crypto: ccp - Initialize PSP when reading psp data file failed Sasha Levin
2022-10-18  0:07 ` [PATCH AUTOSEL 6.0 04/32] gfs2: Switch from strlcpy to strscpy Sasha Levin
2022-10-18  0:07 ` [PATCH AUTOSEL 6.0 05/32] powerpc/hw_breakpoint: Avoid relying on caller synchronization Sasha Levin
2022-10-18  0:07 ` [PATCH AUTOSEL 6.0 06/32] cgroup: Remove data-race around cgrp_dfl_visible Sasha Levin
2022-10-18  0:07 ` [PATCH AUTOSEL 6.0 07/32] iommu/vt-d: Handle race between registration and device probe Sasha Levin
2022-10-18  0:07 ` [PATCH AUTOSEL 6.0 08/32] of/fdt: Don't calculate initrd size from DT if start > end Sasha Levin
2022-10-18  0:07 ` [PATCH AUTOSEL 6.0 09/32] tools/vm/page_owner_sort: fix -f option Sasha Levin
2022-10-18  0:07 ` [PATCH AUTOSEL 6.0 10/32] objtool,x86: Teach decode about LOOP* instructions Sasha Levin
2022-10-18  0:07 ` [PATCH AUTOSEL 6.0 11/32] locking/rwsem: Disable preemption while trying for rwsem lock Sasha Levin
2022-10-18  0:07 ` [PATCH AUTOSEL 6.0 12/32] swiotlb: don't panic! Sasha Levin
2022-10-18  0:07 ` [PATCH AUTOSEL 6.0 13/32] gfs2: Check sb_bsize_shift after reading superblock Sasha Levin
2022-10-18  0:07 ` [PATCH AUTOSEL 6.0 14/32] powerpc/64: don't refer nr_cpu_ids in asm code when it's undefined Sasha Levin
2022-10-18  0:07 ` [PATCH AUTOSEL 6.0 15/32] m68knommu: fix non-specific 68328 choice interrupt build failure Sasha Levin
2022-10-18  0:07 ` [PATCH AUTOSEL 6.0 16/32] m68knommu: fix non-mmu classic 68000 legacy timer tick selection Sasha Levin
2022-10-18  0:07 ` [PATCH AUTOSEL 6.0 17/32] kbuild: take into account DT_SCHEMA_FILES changes while checking dtbs Sasha Levin
2022-10-18  0:07 ` Sasha Levin [this message]
2022-10-18  0:07 ` [PATCH AUTOSEL 6.0 19/32] tracing/user_events: Ensure user provided strings are safely formatted Sasha Levin
2022-10-18  0:07 ` [PATCH AUTOSEL 6.0 20/32] of: Fix "dma-ranges" handling for bus controllers Sasha Levin
2022-10-18  0:07 ` [PATCH AUTOSEL 6.0 21/32] x86/hyperv: Replace kmap() with kmap_local_page() Sasha Levin
2022-10-18  0:07 ` [PATCH AUTOSEL 6.0 22/32] kmsan: disable instrumentation of unsupported common kernel code Sasha Levin
2022-10-18  1:00   ` Marco Elver
2022-10-18  0:07 ` [PATCH AUTOSEL 6.0 23/32] kmsan: disable physical page merging in biovec Sasha Levin
2022-10-18  0:07 ` [PATCH AUTOSEL 6.0 24/32] f2fs: fix wrong dirty page count when race between mmap and fallocate Sasha Levin
2022-10-18  0:07 ` [PATCH AUTOSEL 6.0 25/32] f2fs: code clean and fix a type error Sasha Levin
2022-10-18  0:07 ` [PATCH AUTOSEL 6.0 26/32] f2fs: fix to detect corrupted meta ino Sasha Levin
2022-10-18  0:07 ` [PATCH AUTOSEL 6.0 27/32] 9p: trans_fd/p9_conn_cancel: drop client lock earlier Sasha Levin
2022-10-18  0:07 ` [PATCH AUTOSEL 6.0 28/32] nfsd: fix nfsd_file_unhash_and_dispose Sasha Levin
2022-10-18  0:07 ` [PATCH AUTOSEL 6.0 29/32] 9p/trans_fd: always use O_NONBLOCK read/write Sasha Levin
2022-10-18  0:07 ` [PATCH AUTOSEL 6.0 30/32] net/9p: use a dedicated spinlock for trans_fd Sasha Levin
2022-10-18  0:07 ` [PATCH AUTOSEL 6.0 31/32] virtio_pci: don't try to use intxif pin is zero Sasha Levin
2022-10-18  0:07 ` [PATCH AUTOSEL 6.0 32/32] cifs: replace kfree() with kfree_sensitive() for sensitive data Sasha Levin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221018000729.2730519-18-sashal@kernel.org \
    --to=sashal@kernel.org \
    --cc=beaub@linux.microsoft.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=mingo@redhat.com \
    --cc=rostedt@goodmis.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox