From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D639C4332F for ; Tue, 18 Oct 2022 00:10:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230149AbiJRAJ7 (ORCPT ); Mon, 17 Oct 2022 20:09:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36354 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231488AbiJRAJA (ORCPT ); Mon, 17 Oct 2022 20:09:00 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B193887F94; Mon, 17 Oct 2022 17:08:08 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id C571DB81BEE; Tue, 18 Oct 2022 00:08:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B40EEC433D7; Tue, 18 Oct 2022 00:08:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1666051685; bh=zdh3BLzjF5H1jRyrbPtJfClOlxMTmqavy8H+mOF9K6M=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=OsrHZtmHZDu+vizjSnXUxR6JqlKYhLrwjWyH5eaBvcLyQ/VL2JkPzCv/vVAveeaHj /xTcvLwASu7qg7dIvbuJEytkgDy+aZrC7F1DFy8NWKmoEdXqXdHzoaczJDeKgS4/rY E32YlATJCSNfhiNP+rMUlrU+Pi08I011ikB+87dXtxF3PodwoEeQcMwYJUVu6mFc7N J51BLRSVM0i9Xnhh6a63LaC7etS3vAM1OPUcYQj/6gxQttyzthpsgLCEjPq//sJWR0 bab7C1lKiBtK538hf+390pV2ArpmWDDyh4AvQzxyvdj3cFrr4eI5tzJU5bR34XhGQK mkuHzsA9tZ8vA== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Beau Belgrave , Mathieu Desnoyers , Steven Rostedt , Sasha Levin , mingo@redhat.com Subject: [PATCH AUTOSEL 6.0 18/32] tracing/user_events: Use WRITE instead of READ for io vector import Date: Mon, 17 Oct 2022 20:07:15 -0400 Message-Id: <20221018000729.2730519-18-sashal@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20221018000729.2730519-1-sashal@kernel.org> References: <20221018000729.2730519-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Beau Belgrave [ Upstream commit 95f187603dbff69bef19b2ab3bb54d2c060f556d ] import_single_range expects the direction/rw to be where it came from, not the protection/limit. Since the import is in a write path use WRITE. Link: https://lkml.kernel.org/r/20220728233309.1896-3-beaub@linux.microsoft.com Link: https://lore.kernel.org/all/2059213643.196683.1648499088753.JavaMail.zimbra@efficios.com/ Reported-by: Mathieu Desnoyers Signed-off-by: Beau Belgrave Signed-off-by: Steven Rostedt (Google) Signed-off-by: Sasha Levin --- kernel/trace/trace_events_user.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/kernel/trace/trace_events_user.c b/kernel/trace/trace_events_user.c index a6621c52ce45..b137e1866fbc 100644 --- a/kernel/trace/trace_events_user.c +++ b/kernel/trace/trace_events_user.c @@ -1245,7 +1245,8 @@ static ssize_t user_events_write(struct file *file, const char __user *ubuf, if (unlikely(*ppos != 0)) return -EFAULT; - if (unlikely(import_single_range(READ, (char *)ubuf, count, &iov, &i))) + if (unlikely(import_single_range(WRITE, (char __user *)ubuf, + count, &iov, &i))) return -EFAULT; return user_events_write_core(file, &i); -- 2.35.1