From: Eli Cohen <elic@nvidia.com>
To: <mst@redhat.com>, <jasowang@redhat.com>,
<linux-kernel@vger.kernel.org>,
<virtualization@lists.linux-foundation.org>
Cc: <si-wei.liu@oracle.com>, <eperezma@redhat.com>, <lulu@redhat.com>,
"Eli Cohen" <elic@nvidia.com>
Subject: [PATCH 1/4] vdpa/mlx5: Fix rule forwarding VLAN to TIR
Date: Tue, 18 Oct 2022 14:12:29 +0300 [thread overview]
Message-ID: <20221018111232.4021-2-elic@nvidia.com> (raw)
In-Reply-To: <20221018111232.4021-1-elic@nvidia.com>
Set the VLAN id to the header values field instead of overwriting the
headers criteria field.
Before this fix, VLAN filtering would not really work and tagged packets
would be forwarded unfiltered to the TIR.
Fixes: baf2ad3f6a98 ("vdpa/mlx5: Add RX MAC VLAN filter support")
Signed-off-by: Eli Cohen <elic@nvidia.com>
---
drivers/vdpa/mlx5/net/mlx5_vnet.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/vdpa/mlx5/net/mlx5_vnet.c b/drivers/vdpa/mlx5/net/mlx5_vnet.c
index 90913365def4..dd29fdfc24ed 100644
--- a/drivers/vdpa/mlx5/net/mlx5_vnet.c
+++ b/drivers/vdpa/mlx5/net/mlx5_vnet.c
@@ -1472,7 +1472,7 @@ static int mlx5_vdpa_add_mac_vlan_rules(struct mlx5_vdpa_net *ndev, u8 *mac,
if (tagged) {
MLX5_SET(fte_match_set_lyr_2_4, headers_v, cvlan_tag, 1);
MLX5_SET_TO_ONES(fte_match_set_lyr_2_4, headers_c, first_vid);
- MLX5_SET(fte_match_set_lyr_2_4, headers_c, first_vid, vid);
+ MLX5_SET(fte_match_set_lyr_2_4, headers_v, first_vid, vid);
}
flow_act.action = MLX5_FLOW_CONTEXT_ACTION_FWD_DEST;
dest.type = MLX5_FLOW_DESTINATION_TYPE_TIR;
--
2.35.1
next prev parent reply other threads:[~2022-10-18 11:13 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-18 11:12 [PATCH 0/4] vdpa:/mlx5: Add debugfs subtree Eli Cohen
2022-10-18 11:12 ` Eli Cohen [this message]
2022-10-18 19:20 ` [PATCH 1/4] vdpa/mlx5: Fix rule forwarding VLAN to TIR Si-Wei Liu
2022-10-19 5:31 ` Eli Cohen
2022-10-19 5:34 ` Michael S. Tsirkin
2022-10-19 5:36 ` Eli Cohen
2022-10-19 5:39 ` Michael S. Tsirkin
2022-10-18 11:12 ` [PATCH 2/4] vdpa/mlx5: Move some definitions to a new header file Eli Cohen
2022-10-18 11:12 ` [PATCH 3/4] vdpa/mlx5: Add debugfs subtree Eli Cohen
2022-10-18 19:52 ` Si-Wei Liu
2022-10-19 5:14 ` Jason Wang
2022-10-19 5:37 ` Eli Cohen
2022-10-19 6:07 ` Jason Wang
2022-10-18 11:12 ` [PATCH 4/4] vdpa/mlx5: Add RX counters to debugfs Eli Cohen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221018111232.4021-2-elic@nvidia.com \
--to=elic@nvidia.com \
--cc=eperezma@redhat.com \
--cc=jasowang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lulu@redhat.com \
--cc=mst@redhat.com \
--cc=si-wei.liu@oracle.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox