From: Kees Cook <keescook@chromium.org>
To: Nathan Chancellor <nathan@kernel.org>
Cc: David Gow <davidgow@google.com>,
"Tobin C . Harding" <tobin@kernel.org>,
linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org
Subject: Re: [PATCH] string: Convert strscpy() self-test to KUnit
Date: Tue, 18 Oct 2022 12:00:58 -0700 [thread overview]
Message-ID: <202210181159.1B36049D3@keescook> (raw)
In-Reply-To: <Y072ZMk/hNkfwqMv@dev-arch.thelio-3990X>
On Tue, Oct 18, 2022 at 11:54:28AM -0700, Nathan Chancellor wrote:
> On Tue, Oct 18, 2022 at 01:28:59AM -0700, Kees Cook wrote:
> > Convert the strscpy() self-test to a KUnit test.
> >
> > Cc: David Gow <davidgow@google.com>
> > Cc: Tobin C. Harding <tobin@kernel.org>
> > Signed-off-by: Kees Cook <keescook@chromium.org>
>
> I ran the following commands and they all passed:
>
> $ tools/testing/kunit/kunit.py run --arch arm64 --cross_compile aarch64-linux-gnu- strscpy
>
> $ tools/testing/kunit/kunit.py run --arch arm64 --make_options LLVM=1 strscpy
>
> $ tools/testing/kunit/kunit.py run --arch x86_64 strscpy
>
> $ tools/testing/kunit/kunit.py run --arch x86_64 --make_options LLVM=1 strscpy
>
> Tested-by: Nathan Chancellor <nathan@kernel.org>
Thank you!
I should probably note somewhere that I test it both with and without
CONFIG_FORTIFY_SOURCE:
$ tools/testing/kunit/kunit.py run --arch x86_64 --kconfig_add CONFIG_FORTIFY_SOURCE=y strscpy
etc...
--
Kees Cook
next prev parent reply other threads:[~2022-10-18 19:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-18 8:28 [PATCH] string: Convert strscpy() self-test to KUnit Kees Cook
2022-10-18 18:54 ` Nathan Chancellor
2022-10-18 19:00 ` Kees Cook [this message]
2022-10-19 4:39 ` David Gow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202210181159.1B36049D3@keescook \
--to=keescook@chromium.org \
--cc=davidgow@google.com \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nathan@kernel.org \
--cc=tobin@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox