From: Masami Hiramatsu (Google) <mhiramat@kernel.org>
To: Zheng Yejian <zhengyejian1@huawei.com>
Cc: <rostedt@goodmis.org>, <corbet@lwn.net>,
<linux-doc@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<tom.zanussi@linux.intel.com>
Subject: Re: [PATCH -next] tracing/histogram: Update document for KEYS_MAX size
Date: Wed, 19 Oct 2022 00:31:34 +0900 [thread overview]
Message-ID: <20221019003134.cc24bd624cc6fca06a05206c@kernel.org> (raw)
In-Reply-To: <20221017103806.2479139-1-zhengyejian1@huawei.com>
On Mon, 17 Oct 2022 10:38:06 +0000
Zheng Yejian <zhengyejian1@huawei.com> wrote:
> After commit 4f36c2d85ced ("tracing: Increase tracing map KEYS_MAX size"),
> 'keys' supports up to three fields.
This looks good to me.
Acked-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
Steve, do you this this document fix should go into the stable trees?
Thank you,
>
> Signed-off-by: Zheng Yejian <zhengyejian1@huawei.com>
> ---
> Documentation/trace/histogram.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/trace/histogram.rst b/Documentation/trace/histogram.rst
> index c1b685a38f6b..87bd772836c0 100644
> --- a/Documentation/trace/histogram.rst
> +++ b/Documentation/trace/histogram.rst
> @@ -39,7 +39,7 @@ Documentation written by Tom Zanussi
> will use the event's kernel stacktrace as the key. The keywords
> 'keys' or 'key' can be used to specify keys, and the keywords
> 'values', 'vals', or 'val' can be used to specify values. Compound
> - keys consisting of up to two fields can be specified by the 'keys'
> + keys consisting of up to three fields can be specified by the 'keys'
> keyword. Hashing a compound key produces a unique entry in the
> table for each unique combination of component keys, and can be
> useful for providing more fine-grained summaries of event data.
> --
> 2.25.1
>
--
Masami Hiramatsu (Google) <mhiramat@kernel.org>
next prev parent reply other threads:[~2022-10-18 15:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-17 10:38 [PATCH -next] tracing/histogram: Update document for KEYS_MAX size Zheng Yejian
2022-10-18 15:31 ` Masami Hiramatsu [this message]
2022-10-18 15:35 ` Steven Rostedt
2022-10-18 15:49 ` Jonathan Corbet
2022-10-18 16:18 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221019003134.cc24bd624cc6fca06a05206c@kernel.org \
--to=mhiramat@kernel.org \
--cc=corbet@lwn.net \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=tom.zanussi@linux.intel.com \
--cc=zhengyejian1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox