From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9291BC433FE for ; Thu, 20 Oct 2022 13:46:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229785AbiJTNqQ (ORCPT ); Thu, 20 Oct 2022 09:46:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57906 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229786AbiJTNqG (ORCPT ); Thu, 20 Oct 2022 09:46:06 -0400 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CCECC11874B; Thu, 20 Oct 2022 06:45:52 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id D34C4CE252D; Thu, 20 Oct 2022 13:45:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B4AC2C433C1; Thu, 20 Oct 2022 13:45:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1666273549; bh=gEzBsG2afAcJArkvwrtS1d1ZrUezVmRH4opGNtVPXAQ=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=VJGp3AgHy1aLrltfoH3ZUIY2vPiG8odz2T6+x6jMCxcJgZCwTqS9qB3icoBC8o4E8 E1gfpoW8H0h3qQq/0/EZYuKYCvQC8HL2tkyrpL4XwUeqKy9JVjs4nQoNI/bL0fqMMC fht4bNrhgVpd8SagpFnXZ9RE9junpC95FZ9mZIXzSFLwxrvemWT4v9YJzydgYmRwr9 Dq/0vR7MpzhoHTTfYTeffDWxoum67vJnPgSuWd0+edba3zhaABe6sytQ7LWcvC1QV0 OeDSrpxLauYQmP8C3WM0IafIX95qvt1v+oz6aA+EnOZHYUsc8+crMpW+Mx2cnmWOWH H+9jYGQE6tu6w== Date: Thu, 20 Oct 2022 08:45:47 -0500 From: Bjorn Helgaas To: Conor Dooley Cc: kernel test robot , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Heiko Stuebner , linux-pci@vger.kernel.org, Lorenzo Pieralisi , llvm@lists.linux.dev, Minghuan Lian , Thierry Reding , Thomas Petazzoni , Bharat Kumar Gogada , Toan Le , linux-riscv@lists.infradead.org, Kishon Vijay Abraham I , Rob Herring , Linus Walleij , Joyce Ooi , Jonathan Hunter , linux-arm-kernel@lists.infradead.org, bcm-kernel-feedback-list@broadcom.com, Shawn Lin , Ray Jui , linux-tegra@vger.kernel.org, linux-omap@vger.kernel.org, Mingkai Hu , Roy Zang , Michal Simek , kbuild-all@lists.01.org, Scott Branden , Daire McNamara , linux-kernel@vger.kernel.org, Tom Joseph , linuxppc-dev@lists.ozlabs.org, Pali =?iso-8859-1?Q?Roh=E1r?= Subject: Re: [PATCH] PCI: Remove unnecessary of_irq.h includes Message-ID: <20221020134547.GA94120@bhelgaas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [+cc Pali, heads-up for trivial addition of to pci-mvebu.c] On Thu, Oct 20, 2022 at 08:20:25AM +0100, Conor Dooley wrote: > On Thu, Oct 20, 2022 at 03:08:50PM +0800, kernel test robot wrote: > > Hi Bjorn, > > > > I love your patch! Yet something to improve: > > > > >> drivers/pci/controller/pcie-microchip-host.c:473:31: error: incomplete definition of type 'struct irq_domain' > > struct mc_pcie *port = domain->host_data; > > That's what I get for only visually inspecting the patch before Acking > it.. Un-ack I suppose. No problem! I think what happened is the pcie-microchip-host.c uses irq_domain_add_linear() so it needs , but it currently gets it via , which it doesn't otherwise need. I added a preparatory patch to include explicitly, but I haven't been able to cross-build either riscv or ia64 to verify this fix. I'll wait a few days and post an updated series for the 0-day bot to test. Same situation for pcie-altera-msi.c. pci-mvebu.c also relies on getting via , but it actually depends on of_irq.h, so I'll just add an irqdomain.h include there. Bjorn