From: Dan Carpenter <dan.carpenter@oracle.com>
To: kbuild@lists.01.org, Paolo Valente <paolo.valente@linaro.org>,
Jens Axboe <axboe@kernel.dk>
Cc: lkp@intel.com, kbuild-all@lists.01.org,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
glen.valante@linaro.org, arie.vanderhoeven@seagate.com,
rory.c.chen@seagate.com, Paolo Valente <paolo.valente@linaro.org>,
Gabriele Felici <felicigb@gmail.com>,
Carmine Zaccagnino <carmine@carminezacc.com>
Subject: [kbuild] Re: [PATCH V4 1/8] block, bfq: split sync bfq_queues on a per-actuator basis
Date: Fri, 21 Oct 2022 15:56:26 +0300 [thread overview]
Message-ID: <202210212014.ynAHDVJU-lkp@intel.com> (raw)
In-Reply-To: <20221020152643.21199-2-paolo.valente@linaro.org>
Hi Paolo,
https://git-scm.com/docs/git-format-patch#_base_tree_information ]
url: https://github.com/intel-lab-lkp/linux/commits/Paolo-Valente/block-bfq-extend-bfq-to-support-multi-actuator-drives/20221020-233011
base: https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git for-next
patch link: https://lore.kernel.org/r/20221020152643.21199-2-paolo.valente%40linaro.org
patch subject: [PATCH V4 1/8] block, bfq: split sync bfq_queues on a per-actuator basis
config: openrisc-randconfig-m041-20221019
compiler: or1k-linux-gcc (GCC) 12.1.0
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
New smatch warnings:
block/bfq-iosched.c:5423 bfq_exit_icq() error: we previously assumed 'bfqd' could be null (see line 5420)
block/bfq-iosched.c:5431 bfq_exit_icq() warn: variable dereferenced before check 'bfqd' (see line 5423)
Old smatch warnings:
block/bfq-iosched.c:6115 __bfq_insert_request() warn: variable dereferenced before check 'bfqq' (see line 6111)
vim +/bfqd +5423 block/bfq-iosched.c
aee69d78dec0ff Paolo Valente 2017-04-19 5409 static void bfq_exit_icq(struct io_cq *icq)
aee69d78dec0ff Paolo Valente 2017-04-19 5410 {
aee69d78dec0ff Paolo Valente 2017-04-19 5411 struct bfq_io_cq *bic = icq_to_bic(icq);
fc8f914d9fc5a0 Paolo Valente 2022-10-20 5412 struct bfq_data *bfqd = bic_to_bfqd(bic);
fc8f914d9fc5a0 Paolo Valente 2022-10-20 5413 unsigned long flags;
fc8f914d9fc5a0 Paolo Valente 2022-10-20 5414 unsigned int act_idx;
430a67f9d6169a Paolo Valente 2021-03-04 5415
430a67f9d6169a Paolo Valente 2021-03-04 5416 /*
fc8f914d9fc5a0 Paolo Valente 2022-10-20 5417 * bfqd is NULL if scheduler already exited, and in that case
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
fc8f914d9fc5a0 Paolo Valente 2022-10-20 5418 * this is the last time these queues are accessed.
430a67f9d6169a Paolo Valente 2021-03-04 5419 */
fc8f914d9fc5a0 Paolo Valente 2022-10-20 @5420 if (bfqd)
430a67f9d6169a Paolo Valente 2021-03-04 5421 spin_lock_irqsave(&bfqd->lock, flags);
fc8f914d9fc5a0 Paolo Valente 2022-10-20 5422
fc8f914d9fc5a0 Paolo Valente 2022-10-20 @5423 for (act_idx = 0; act_idx < bfqd->num_actuators; act_idx++) {
^^^^^^^^^^^^^^^^^^^
If "bfqd" is NULL then we're toasted.
fc8f914d9fc5a0 Paolo Valente 2022-10-20 5424 if (bic->stable_merge_bfqq)
430a67f9d6169a Paolo Valente 2021-03-04 5425 bfq_put_stable_ref(bic->stable_merge_bfqq);
fc8f914d9fc5a0 Paolo Valente 2022-10-20 5426
fc8f914d9fc5a0 Paolo Valente 2022-10-20 5427 bfq_exit_icq_bfqq(bic, true, act_idx);
fc8f914d9fc5a0 Paolo Valente 2022-10-20 5428 bfq_exit_icq_bfqq(bic, false, act_idx);
430a67f9d6169a Paolo Valente 2021-03-04 5429 }
430a67f9d6169a Paolo Valente 2021-03-04 5430
fc8f914d9fc5a0 Paolo Valente 2022-10-20 @5431 if (bfqd)
fc8f914d9fc5a0 Paolo Valente 2022-10-20 5432 spin_unlock_irqrestore(&bfqd->lock, flags);
aee69d78dec0ff Paolo Valente 2017-04-19 5433 }
--
0-DAY CI Kernel Test Service
https://01.org/lkp
next prev parent reply other threads:[~2022-10-21 12:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-20 15:26 [PATCH V4 0/8] block, bfq: extend bfq to support multi-actuator drives Paolo Valente
2022-10-20 15:26 ` [PATCH V4 1/8] block, bfq: split sync bfq_queues on a per-actuator basis Paolo Valente
2022-10-21 12:56 ` Dan Carpenter [this message]
2022-10-28 2:50 ` Rory Chen
2022-10-28 9:24 ` Paolo Valente
2022-10-20 15:26 ` [PATCH V4 2/8] block, bfq: forbid stable merging of queues associated with different actuators Paolo Valente
2022-10-20 15:26 ` [PATCH V4 3/8] block, bfq: move io_cq-persistent bfqq data into a dedicated struct Paolo Valente
2022-10-20 22:54 ` Damien Le Moal
2022-10-20 15:26 ` [PATCH V4 4/8] block, bfq: turn bfqq_data into an array in bfq_io_cq Paolo Valente
2022-10-20 15:26 ` [PATCH V4 5/8] block, bfq: split also async bfq_queues on a per-actuator basis Paolo Valente
2022-10-20 15:26 ` [PATCH V4 6/8] block, bfq: retrieve independent access ranges from request queue Paolo Valente
2022-10-20 15:26 ` [PATCH V4 7/8] block, bfq: inject I/O to underutilized actuators Paolo Valente
2022-10-20 15:26 ` [PATCH V4 8/8] block, bfq: balance I/O injection among " Paolo Valente
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202210212014.ynAHDVJU-lkp@intel.com \
--to=dan.carpenter@oracle.com \
--cc=arie.vanderhoeven@seagate.com \
--cc=axboe@kernel.dk \
--cc=carmine@carminezacc.com \
--cc=felicigb@gmail.com \
--cc=glen.valante@linaro.org \
--cc=kbuild-all@lists.01.org \
--cc=kbuild@lists.01.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=paolo.valente@linaro.org \
--cc=rory.c.chen@seagate.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox