[PATCH 00/11] mm/damon: cleanup and refactoring code

SeongJae Park
2022-10-24T22:29:49Z

This patchset cleans up and refactors a range of DAMON code including
the core, DAMON sysfs interface, and DAMON modules, for better
readability and convenient future feature implementations.

In detail, this patchset splits unnecessarily long and complex functions
in core into smaller functions (patches 1-4). Then, it cleans up the
DAMON sysfs interface by using more type-safe code (patch 5) and
removing unnecessary function parameters (patch 6). Further, it
refactor the code by distributing the code into multiple files (patches
7-9). Last two patches (patches 10 and 11) deduplicates and remove
unnecessary header inclusion in DAMON modules (reclaim and lru_sort).

Note that this initially posted as a part of a feature implementation
RFC patchset[1], but separated into this patchset as the amount of the
change is not small compared to the feature implementation change
itself.

[1] https://lore.kernel.org/damon/20221019001317.104270-1-sj@kernel.org/

SeongJae Park (11):
mm/damon/core: split out DAMOS-charged region skip logic into a new
function
mm/damon/core: split damos application logic into a new function
mm/damon/core: split out scheme stat update logic into a new function
mm/damon/core: split out scheme quota adjustment logic into a new
function
mm/damon/sysfs: use damon_addr_range for regions' start and end values
mm/damon/sysfs: remove parameters of damon_sysfs_region_alloc()
mm/damon/sysfs: move sysfs_lock to common module
mm/damon/sysfs: move unsigned long range directory to common module
mm/damon/sysfs: split out kdamond-independent schemes stats update
logic into a new function
mm/damon/modules: deduplicate init steps for DAMON context setup
mm/damon/{reclaim,lru_sort}: remove unnecessarily included headers

mm/damon/Makefile | 6 +-
mm/damon/core.c | 262 +++++++++++++++++++++++---------------
mm/damon/lru_sort.c | 19 +--
mm/damon/modules-common.c | 42 ++++++
mm/damon/modules-common.h | 3 +
mm/damon/reclaim.c | 19 +--
mm/damon/sysfs-common.c | 107 ++++++++++++++++
mm/damon/sysfs-common.h | 24 ++++
mm/damon/sysfs.c | 172 +++++--------------------
9 files changed, 374 insertions(+), 280 deletions(-)
create mode 100644 mm/damon/modules-common.c
create mode 100644 mm/damon/sysfs-common.c
create mode 100644 mm/damon/sysfs-common.h

--
2.25.1