Re: [PATCH] wifi: ath10k: Add WLAN firmware image version info into smem

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 4341 bytes --]

Hi Youghandhar,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on kvalo-ath/ath-next]
[also build test WARNING on wireless/main wireless-next/main linus/master v6.1-rc2 next-20221026]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Youghandhar-Chintala/wifi-ath10k-Add-WLAN-firmware-image-version-info-into-smem/20221026-182411
base:   https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git ath-next
patch link:    https://lore.kernel.org/r/20221026102257.19919-1-quic_youghand%40quicinc.com
patch subject: [PATCH] wifi: ath10k: Add WLAN firmware image version info into smem
config: ia64-allyesconfig (attached as .config)
compiler: ia64-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/8faae971fb76b9c21178b19d7e9c37519cda06e1
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Youghandhar-Chintala/wifi-ath10k-Add-WLAN-firmware-image-version-info-into-smem/20221026-182411
        git checkout 8faae971fb76b9c21178b19d7e9c37519cda06e1
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=ia64 SHELL=/bin/bash drivers/net/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   In file included from drivers/net/wireless/ath/ath10k/qmi.c:21:
   drivers/net/wireless/ath/ath10k/qmi.c: In function 'ath10k_qmi_add_wlan_ver_smem':
>> drivers/net/wireless/ath/ath10k/qmi.c:557:48: warning: format '%i' expects argument of type 'int', but argument 4 has type 'size_t' {aka 'long unsigned int'} [-Wformat=]
     557 |                 ath10k_dbg(ar, ATH10K_DBG_QMI, "smem block size too small: %i",
         |                                                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     558 |                            smem_block_size);
         |                            ~~~~~~~~~~~~~~~      
         |                            |
         |                            size_t {aka long unsigned int}
   drivers/net/wireless/ath/ath10k/debug.h:286:44: note: in definition of macro 'ath10k_dbg'
     286 |                 __ath10k_dbg(ar, dbg_mask, fmt, ##__VA_ARGS__); \
         |                                            ^~~
   drivers/net/wireless/ath/ath10k/qmi.c:557:77: note: format string is defined here
     557 |                 ath10k_dbg(ar, ATH10K_DBG_QMI, "smem block size too small: %i",
         |                                                                            ~^
         |                                                                             |
         |                                                                             int
         |                                                                            %li


vim +557 drivers/net/wireless/ath/ath10k/qmi.c

   541	
   542	static void ath10k_qmi_add_wlan_ver_smem(struct ath10k *ar, char *fw_build_id)
   543	{
   544		u8 *smem_table_ptr;
   545		size_t smem_block_size;
   546		const u32 version_string_size = 128;
   547		const u32 smem_img_idx_wlan = ATH10K_SMEM_IMAGE_TABLE_CNSS_INDEX * 128;
   548	
   549		smem_table_ptr = qcom_smem_get(QCOM_SMEM_HOST_ANY,
   550					       ATH10K_SMEM_IMAGE_VERSION_TABLE,
   551					       &smem_block_size);
   552		if (IS_ERR(smem_table_ptr)) {
   553			ath10k_dbg(ar, ATH10K_DBG_QMI, "smem image version table not found");
   554			return;
   555		}
   556		if (smem_img_idx_wlan + version_string_size > smem_block_size) {
 > 557			ath10k_dbg(ar, ATH10K_DBG_QMI, "smem block size too small: %i",
   558				   smem_block_size);
   559			return;
   560		}
   561		memcpy(smem_table_ptr + smem_img_idx_wlan, fw_build_id,
   562		       version_string_size);
   563	}
   564	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 74297 bytes --]