From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 839D5C38A2D for ; Thu, 27 Oct 2022 01:05:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233677AbiJ0BFR (ORCPT ); Wed, 26 Oct 2022 21:05:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52926 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233441AbiJ0BFM (ORCPT ); Wed, 26 Oct 2022 21:05:12 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2ED9838694; Wed, 26 Oct 2022 18:05:08 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 21EBC620F8; Thu, 27 Oct 2022 01:05:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6DB29C433C1; Thu, 27 Oct 2022 01:05:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1666832707; bh=+Ez6WYsZqAn0lFGyPn93VnnIIVFNJD0XEuX7LXud3cE=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=iFrmBz3httCqrIx0lE6e101vtRv16cTLD8oEUDv0F952mlDhMZPYF99WlOJpwb6x1 lJMj36WoRTdb1pZIEF6r1N7UJyOQ5a4gQN7nsQfypK4/8dVGCUBg4t1xVgLc6kCVEv XVYHFyzvs4aW3THyOsF19NOWchIS9efHqSnJGfHdm34rcQsOMEBm4arGDjkimXrKqE nMxMMnnU4bpIyYmrmNLLAv0Scgl8vdN3Sb3ZYg1Pw4JGJW4v3kjTRvLVWA07r5qvht shNDxt5vIZ6TXq/QjWhNrlNaDseGfQcu7J8XjE+I/9D2TBqoa3em4CBWwjXAjVjIkF GRHRGXGMue+pw== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <49e339d4739e4ae4c92b00c1b2918af0755d4122.1666695221.git.rtanwar@maxlinear.com> References: <49e339d4739e4ae4c92b00c1b2918af0755d4122.1666695221.git.rtanwar@maxlinear.com> Subject: Re: [PATCH 1/1] clk: mxl: Fix smatch static checker warning From: Stephen Boyd Cc: linux-kernel@vger.kernel.org, linux-lgm-soc@maxlinear.com, Rahul Tanwar To: Rahul Tanwar , dan.carpenter@oracle.com, linux-clk@vger.kernel.org, yzhu@maxlinear.com Date: Wed, 26 Oct 2022 18:05:05 -0700 User-Agent: alot/0.10 Message-Id: <20221027010507.6DB29C433C1@smtp.kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Rahul Tanwar (2022-10-25 04:03:57) > Commit 036177310bac: ("clk: mxl: Switch from direct readl/writel based IO= to > regmap based IO") introduced code resulting in below warning issued by the > smatch static checker. >=20 > drivers/clk/x86/clk-lgm.c:441 lgm_cgu_probe() > warn: passing zero to 'PTR_ERR' >=20 > Fix the warning by replacing incorrect IS_ERR_OR_NULL() with IS_ERR(). >=20 > Fixes: 036177310bac: ("clk: mxl: Switch from direct readl/writel based IO= to > regmap based IO") > Reported-by: Dan Carpenter > Signed-off-by: Rahul Tanwar > --- Applied to clk-next BTW, please don't send a cover letter for single patches.