From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8157FA3740 for ; Thu, 27 Oct 2022 17:13:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235861AbiJ0RNZ (ORCPT ); Thu, 27 Oct 2022 13:13:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53154 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236201AbiJ0RNW (ORCPT ); Thu, 27 Oct 2022 13:13:22 -0400 Received: from 1wt.eu (wtarreau.pck.nerim.net [62.212.114.60]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 2C2E91A2E23; Thu, 27 Oct 2022 10:13:19 -0700 (PDT) Received: (from willy@localhost) by pcw.home.local (8.15.2/8.15.2/Submit) id 29RHD84B031359; Thu, 27 Oct 2022 19:13:08 +0200 Date: Thu, 27 Oct 2022 19:13:08 +0200 From: Willy Tarreau To: "Paul E. McKenney" Cc: linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] selftests/nolibc: always rebuild the sysroot when running a test Message-ID: <20221027171307.GA30081@1wt.eu> References: <20221026054508.19634-1-w@1wt.eu> <20221026164825.GN5600@paulmck-ThinkPad-P17-Gen-1> <20221026195902.GB24197@1wt.eu> <20221026204138.GQ5600@paulmck-ThinkPad-P17-Gen-1> <20221027023456.GA26215@1wt.eu> <20221027170453.GA5600@paulmck-ThinkPad-P17-Gen-1> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221027170453.GA5600@paulmck-ThinkPad-P17-Gen-1> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 27, 2022 at 10:04:53AM -0700, Paul E. McKenney wrote: > > > My intent is to push these nolicb patches into the upcoming v6.2 > > > merge window: > > > > > > 2318a710bffbd tools/nolibc: Fix missing strlen() definition and infinite loop with gcc-12 > > > 6937b8de8f1c3 tools/nolibc/string: Fix memcmp() implementation > > > e1bbfe393c900 selftests/nolibc: Add 7 tests for memcmp() > > > 3f2c1c45a3a9a selftests/nolibc: Always rebuild the sysroot when running a test > > > > > > I didn't see the problem until I queued the third patch (e1bbfe393c900), > > > and it is still in -rcu, not in v6.1. > > > > > > What am I missing here? > > > > I thought that since some of them are fixes, they would be pushed during > > 6.1-rc so that we don't release 6.1 with known defects. For example Rasmus' > > fix for memcmp() or the strlen() fix would IMHO make sense for this > > release since we're aware of the bugs and we have the fixes. The 3rd one > > is indeed an addition and in no way a fix and it can easily wait for 6.2. > > The 4th one is more of a usability fix but I agree that for this last one > > it's debatable, I was mostly seeing this as a possiility to avoid causing > > needless confusion. > > > > Hoping this clarifies my initial question. > > Very much so, thank you! > > I was not considering the bug fixed by the first two patches to be > serious, my mistake, apologies for my misclassification. No worries, I wasn't probably clear upfront about the purpose. > Given that background, I would rebase these two, test them, and send > off a pull request, probably early next week. > > 2318a710bffbd tools/nolibc: Fix missing strlen() definition and infinite loop with gcc-12 > 6937b8de8f1c3 tools/nolibc/string: Fix memcmp() implementation Perfect, thank you! > I would push the other two commits into the upcoming merge window. OK! > Or might the discussion between you and Rasmus result in changes to > either of those first two commits? If so, I should of course wait for > that discussion to resolve. We'll see, but in any case it would just be a minor detail, but I'll give you a quick response so that you don't have to deal with multiple versions of the patch, we all know that it's painful. Thanks! Willy