From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31FD6C38A02 for ; Sun, 30 Oct 2022 07:37:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229833AbiJ3HhA (ORCPT ); Sun, 30 Oct 2022 03:37:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33882 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229576AbiJ3Hg5 (ORCPT ); Sun, 30 Oct 2022 03:36:57 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 17FAD296; Sun, 30 Oct 2022 00:36:56 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id 69D5168AA6; Sun, 30 Oct 2022 08:36:52 +0100 (CET) Date: Sun, 30 Oct 2022 08:36:52 +0100 From: Christoph Hellwig To: Dawei Li Cc: axboe@kernel.dk, bvanassche@acm.org, hch@lst.de, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] block: simplify blksize_bits() implementation Message-ID: <20221030073651.GA4131@lst.de> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I'm not sure if it matters, but the change does look fine to me: Reviewed-by: Christoph Hellwig