From: Christoph Hellwig <hch@lst.de>
To: Jinlong Chen <nickyc975@zju.edu.cn>
Cc: axboe@kernel.dk, kbusch@kernel.org, hch@lst.de, sagi@grimberg.me,
bvanassche@acm.org, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org
Subject: Re: [RESEND PATCH v2 2/3] blk-mq: remove blk_freeze_queue
Date: Sun, 30 Oct 2022 08:38:42 +0100 [thread overview]
Message-ID: <20221030073842.GC4131@lst.de> (raw)
In-Reply-To: <e21821b72fe9df4f187c1321dd38587138cd1aaa.1667107410.git.nickyc975@zju.edu.cn>
On Sun, Oct 30, 2022 at 01:26:45PM +0800, Jinlong Chen wrote:
> Nobody is calling blk_freeze_queue except its alias, so remove it.
So while we really do not need both names - the queue freezing is also
used for non-mq drivers, so the naming without the mq is actually the
slightly more correct one. But for that it should also move out of
blk-mq.c, so I'm not really sure touching this right now is all that
helpful.
next prev parent reply other threads:[~2022-10-30 7:38 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-30 5:26 [RESEND PATCH v2 0/3] queue freezing improvement and cleanups Jinlong Chen
2022-10-30 5:26 ` [RESEND PATCH v2 1/3] blk-mq: remove redundant call to blk_freeze_queue_start in blk_mq_destroy_queue Jinlong Chen
2022-10-30 7:37 ` Christoph Hellwig
2022-10-30 5:26 ` [RESEND PATCH v2 2/3] blk-mq: remove blk_freeze_queue Jinlong Chen
2022-10-30 7:38 ` Christoph Hellwig [this message]
2022-10-30 5:26 ` [RESEND PATCH v2 3/3] block: hide back blk_freeze_queue_start and export its blk-mq alias Jinlong Chen
2022-10-30 7:40 ` Christoph Hellwig
2022-10-30 8:19 ` Jinlong Chen
2022-10-30 8:21 ` Christoph Hellwig
2022-10-30 8:35 ` Jinlong Chen
2022-10-31 7:28 ` kernel test robot
2022-10-31 13:05 ` Jinlong Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221030073842.GC4131@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=nickyc975@zju.edu.cn \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox