From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06AD2FA373D for ; Sun, 30 Oct 2022 07:38:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229520AbiJ3Hit (ORCPT ); Sun, 30 Oct 2022 03:38:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35002 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229476AbiJ3Hiq (ORCPT ); Sun, 30 Oct 2022 03:38:46 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 901CD2C7; Sun, 30 Oct 2022 00:38:45 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id F36F268AFE; Sun, 30 Oct 2022 08:38:42 +0100 (CET) Date: Sun, 30 Oct 2022 08:38:42 +0100 From: Christoph Hellwig To: Jinlong Chen Cc: axboe@kernel.dk, kbusch@kernel.org, hch@lst.de, sagi@grimberg.me, bvanassche@acm.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org Subject: Re: [RESEND PATCH v2 2/3] blk-mq: remove blk_freeze_queue Message-ID: <20221030073842.GC4131@lst.de> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Oct 30, 2022 at 01:26:45PM +0800, Jinlong Chen wrote: > Nobody is calling blk_freeze_queue except its alias, so remove it. So while we really do not need both names - the queue freezing is also used for non-mq drivers, so the naming without the mq is actually the slightly more correct one. But for that it should also move out of blk-mq.c, so I'm not really sure touching this right now is all that helpful.