From: Rob Herring <robh@kernel.org>
To: "Nícolas F. R. A. Prado" <nfraprado@collabora.com>
Cc: Mark Brown <broonie@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
kernel@collabora.com,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Jaroslav Kysela <perex@perex.cz>,
Liam Girdwood <lgirdwood@gmail.com>,
Oder Chiou <oder_chiou@realtek.com>,
Takashi Iwai <tiwai@suse.com>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 6/8] ASoC: rt5682: Support dbvdd and ldo1-in supplies
Date: Mon, 31 Oct 2022 14:09:38 -0500 [thread overview]
Message-ID: <20221031190938.GA3264845-robh@kernel.org> (raw)
In-Reply-To: <20221031163140.h63kjpivwg7xpvs3@notapiano>
On Mon, Oct 31, 2022 at 12:31:40PM -0400, Nícolas F. R. A. Prado wrote:
> On Mon, Oct 31, 2022 at 01:09:28PM +0000, Mark Brown wrote:
> > On Fri, Oct 28, 2022 at 04:55:38PM -0400, Nícolas F. R. A. Prado wrote:
> >
> > > @@ -35,6 +35,8 @@ const char *rt5682_supply_names[RT5682_NUM_SUPPLIES] = {
> > > "AVDD",
> > > "MICVDD",
> > > "VBAT",
> > > + "dbvdd",
> > > + "ldo1-in",
> >
> > Why are we making these inconsistent in style with the other supplies?
>
> In short because the other supplies already have users while these are new ones.
> My understanding was that new supplies should have lowercase names, following DT
> convention. But I do see the argument on having them all be consistent for a
> single driver/binding. If there are no remarks from Rob or Krzysztof I can
> change it in the next version.
We want lowercase and consistency... Between the 2, I pick consistency.
Rob
next prev parent reply other threads:[~2022-10-31 19:09 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-28 20:55 [PATCH 0/8] Adjust usage of rt5682(s) power supply properties Nícolas F. R. A. Prado
2022-10-28 20:55 ` [PATCH 1/8] ASoC: dt-bindings: realtek,rt5682s: Add AVDD and MICVDD supplies Nícolas F. R. A. Prado
2022-10-31 12:53 ` AngeloGioacchino Del Regno
2022-10-28 20:55 ` [PATCH 2/8] ASoC: dt-bindings: realtek,rt5682s: Add dbvdd and ldo1-in supplies Nícolas F. R. A. Prado
2022-10-31 12:53 ` AngeloGioacchino Del Regno
2022-11-03 22:26 ` Krzysztof Kozlowski
2022-10-28 20:55 ` [PATCH 3/8] ASoC: dt-bindings: rt5682: Add AVDD, MICVDD and VBAT supplies Nícolas F. R. A. Prado
2022-10-28 20:55 ` [PATCH 4/8] ASoC: dt-bindings: rt5682: Add dbvdd and ldo1-in supplies Nícolas F. R. A. Prado
2022-11-03 22:26 ` Krzysztof Kozlowski
2022-10-28 20:55 ` [PATCH 5/8] ASoC: rt5682s: Support " Nícolas F. R. A. Prado
2022-10-31 12:53 ` AngeloGioacchino Del Regno
2022-10-28 20:55 ` [PATCH 6/8] ASoC: rt5682: " Nícolas F. R. A. Prado
2022-10-31 12:53 ` AngeloGioacchino Del Regno
2022-10-31 13:09 ` Mark Brown
2022-10-31 13:41 ` AngeloGioacchino Del Regno
2022-10-31 16:31 ` Nícolas F. R. A. Prado
2022-10-31 19:09 ` Rob Herring [this message]
2022-10-31 19:38 ` Nícolas F. R. A. Prado
2022-10-31 21:54 ` Mark Brown
2022-10-28 20:55 ` [PATCH 7/8] arm64: dts: qcom: sc7180-trogdor: Add missing supplies for rt5682 Nícolas F. R. A. Prado
2022-10-31 12:54 ` AngeloGioacchino Del Regno
2022-10-28 20:55 ` [PATCH 8/8] arm64: dts: qcom: sc7180-trogdor: Remove VBAT supply from rt5682s Nícolas F. R. A. Prado
2022-10-31 12:56 ` AngeloGioacchino Del Regno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221031190938.GA3264845-robh@kernel.org \
--to=robh@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=andersson@kernel.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=broonie@kernel.org \
--cc=kernel@collabora.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nfraprado@collabora.com \
--cc=oder_chiou@realtek.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox