From: Jerom van der Sar <jerom.vandersar@gmail.com>
To: gregkh@linuxfoundation.org
Cc: philipp.g.hortmann@gmail.com, error27@gmail.com,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
Jerom van der Sar <jerom.vandersar@gmail.com>
Subject: [PATCH v4] staging: rtl8192e: space formatting fixes in rtl_cam.c
Date: Wed, 2 Nov 2022 21:00:58 +0100 [thread overview]
Message-ID: <20221102200057.397-1-jerom.vandersar@gmail.com> (raw)
In-Reply-To: <Y2IbI8ib5+k+bVRo@kroah.com>
Fixed a few coding style issues in rtl_cam.c: two times lack of
spaces around binary operators. Some other warnings still remain.
These issues were found by scripts/checkpatch.pl.
This patch helps clean up the rtl8192e driver in staging, making it
easier to read and maintain.
Signed-off-by: Jerom van der Sar <jerom.vandersar@gmail.com>
---
Changes in v4:
- Reverted more double blank line formatting fixes to make the patch
even smaller.
Changes in v3:
- Fixed faulty dot at the end of the patch sign-off.
Changes in v2:
- Reverted some formatting fixes to make the diff easier to review.
drivers/staging/rtl8192e/rtl8192e/rtl_cam.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_cam.c b/drivers/staging/rtl8192e/rtl8192e/rtl_cam.c
index 41faeb4b9b9b..41bff46d1b3a 100644
--- a/drivers/staging/rtl8192e/rtl8192e/rtl_cam.c
+++ b/drivers/staging/rtl8192e/rtl8192e/rtl_cam.c
@@ -17,7 +17,7 @@ void rtl92e_cam_reset(struct net_device *dev)
{
u32 ulcommand = 0;
- ulcommand |= BIT31|BIT30;
+ ulcommand |= BIT31 | BIT30;
rtl92e_writel(dev, RWCAM, ulcommand);
}
@@ -107,7 +107,7 @@ void rtl92e_set_key(struct net_device *dev, u8 EntryNo, u8 KeyIndex,
for (i = 0; i < CAM_CONTENT_COUNT; i++) {
TargetCommand = i + CAM_CONTENT_COUNT * EntryNo;
- TargetCommand |= BIT31|BIT16;
+ TargetCommand |= BIT31 | BIT16;
if (i == 0) {
TargetContent = (u32)(*(MacAddr+0)) << 16 |
--
2.34.1
next prev parent reply other threads:[~2022-11-02 20:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-31 22:51 [PATCH] staging: rtl8192e: cleanup coding style issues with spacing Jerom van der Sar
2022-10-31 23:07 ` Philipp Hortmann
2022-11-01 21:52 ` [PATCH v2] staging: rtl8192e: space formatting fixes in rtl_cam.c Jerom van der Sar
2022-11-01 22:07 ` Philipp Hortmann
2022-11-01 22:25 ` Jerom van der Sar
2022-11-01 22:29 ` [PATCH v3] " Jerom van der Sar
2022-11-02 7:24 ` Greg KH
2022-11-02 20:00 ` Jerom van der Sar [this message]
2022-11-02 22:00 ` [PATCH v4] " Philipp Hortmann
2022-11-08 15:21 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221102200057.397-1-jerom.vandersar@gmail.com \
--to=jerom.vandersar@gmail.com \
--cc=error27@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=philipp.g.hortmann@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox