* [PATCH linux-next] x86/MCE/AMD: remove redundant ret variable
@ 2022-11-02 12:37 zhang.songyi
0 siblings, 0 replies; only message in thread
From: zhang.songyi @ 2022-11-02 12:37 UTC (permalink / raw)
To: tony.luck
Cc: bp, tglx, mingo, dave.hansen, x86, hpa, linux-edac, linux-kernel,
jiang.xuexin, xue.zhihong, zhang.songyi
From 7fd536f480bfd526f40870c1567caf3263a584e7 Mon Sep 17 00:00:00 2001
From: zhang songyi <zhang.songyi@zte.com.cn>
Date: Wed, 2 Nov 2022 16:48:44 +0800
Subject: [PATCH linux-next] x86/MCE/AMD: remove redundant ret variable
Return value from show() and store() directly instead of taking this in
another redundant variable.
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: zhang songyi <zhang.songyi@zte.com.cn>
---
arch/x86/kernel/cpu/mce/amd.c | 10 ++--------
1 file changed, 2 insertions(+), 8 deletions(-)
diff --git a/arch/x86/kernel/cpu/mce/amd.c b/arch/x86/kernel/cpu/mce/amd.c
index 10fb5b5c9efa..425d0803eeb6 100644
--- a/arch/x86/kernel/cpu/mce/amd.c
+++ b/arch/x86/kernel/cpu/mce/amd.c
@@ -1009,11 +1009,8 @@ static ssize_t show(struct kobject *kobj, struct attribute *attr, char *buf)
{
struct threshold_block *b = to_block(kobj);
struct threshold_attr *a = to_attr(attr);
- ssize_t ret;
- ret = a->show ? a->show(b, buf) : -EIO;
-
- return ret;
+ return a->show ? a->show(b, buf) : -EIO;
}
static ssize_t store(struct kobject *kobj, struct attribute *attr,
@@ -1021,11 +1018,8 @@ static ssize_t store(struct kobject *kobj, struct attribute *attr,
{
struct threshold_block *b = to_block(kobj);
struct threshold_attr *a = to_attr(attr);
- ssize_t ret;
-
- ret = a->store ? a->store(b, buf, count) : -EIO;
- return ret;
+ return a->store ? a->store(b, buf, count) : -EIO;
}
static const struct sysfs_ops threshold_ops = {
--
2.15.2
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2022-11-02 12:45 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-11-02 12:37 [PATCH linux-next] x86/MCE/AMD: remove redundant ret variable zhang.songyi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox