From: Guenter Roeck <linux@roeck-us.net>
To: Eddie James <eajames@linux.ibm.com>
Cc: linux-watchdog@vger.kernel.org, wim@linux-watchdog.org,
joel@jms.id.au, andrew@aj.id.au, linux-aspeed@lists.ozlabs.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] ARM: dts: aspeed: Setup watchdog pre-timeout interrupt
Date: Wed, 2 Nov 2022 14:00:33 -0700 [thread overview]
Message-ID: <20221102210033.GA2090211@roeck-us.net> (raw)
In-Reply-To: <20221101205338.577427-3-eajames@linux.ibm.com>
On Tue, Nov 01, 2022 at 03:53:38PM -0500, Eddie James wrote:
> Specify the interrupt lines for the base SOCs that support it.
>
> Signed-off-by: Eddie James <eajames@linux.ibm.com>
Acked-by: Guenter Roeck <linux@roeck-us.net>
> ---
> arch/arm/boot/dts/aspeed-g5.dtsi | 3 +++
> arch/arm/boot/dts/aspeed-g6.dtsi | 4 ++++
> 2 files changed, 7 insertions(+)
>
> diff --git a/arch/arm/boot/dts/aspeed-g5.dtsi b/arch/arm/boot/dts/aspeed-g5.dtsi
> index 04f98d1dbb97..b4b98bf38e48 100644
> --- a/arch/arm/boot/dts/aspeed-g5.dtsi
> +++ b/arch/arm/boot/dts/aspeed-g5.dtsi
> @@ -410,18 +410,21 @@ wdt1: watchdog@1e785000 {
> compatible = "aspeed,ast2500-wdt";
> reg = <0x1e785000 0x20>;
> clocks = <&syscon ASPEED_CLK_APB>;
> + interrupts = <27>;
> };
>
> wdt2: watchdog@1e785020 {
> compatible = "aspeed,ast2500-wdt";
> reg = <0x1e785020 0x20>;
> clocks = <&syscon ASPEED_CLK_APB>;
> + interrupts = <27>;
> };
>
> wdt3: watchdog@1e785040 {
> compatible = "aspeed,ast2500-wdt";
> reg = <0x1e785040 0x20>;
> clocks = <&syscon ASPEED_CLK_APB>;
> + interrupts = <27>;
> status = "disabled";
> };
>
> diff --git a/arch/arm/boot/dts/aspeed-g6.dtsi b/arch/arm/boot/dts/aspeed-g6.dtsi
> index ebbcfe445d9c..d9379fd7b1c2 100644
> --- a/arch/arm/boot/dts/aspeed-g6.dtsi
> +++ b/arch/arm/boot/dts/aspeed-g6.dtsi
> @@ -539,23 +539,27 @@ uart5: serial@1e784000 {
>
> wdt1: watchdog@1e785000 {
> compatible = "aspeed,ast2600-wdt";
> + interrupts = <GIC_SPI 24 IRQ_TYPE_LEVEL_HIGH>;
> reg = <0x1e785000 0x40>;
> };
>
> wdt2: watchdog@1e785040 {
> compatible = "aspeed,ast2600-wdt";
> + interrupts = <GIC_SPI 24 IRQ_TYPE_LEVEL_HIGH>;
> reg = <0x1e785040 0x40>;
> status = "disabled";
> };
>
> wdt3: watchdog@1e785080 {
> compatible = "aspeed,ast2600-wdt";
> + interrupts = <GIC_SPI 24 IRQ_TYPE_LEVEL_HIGH>;
> reg = <0x1e785080 0x40>;
> status = "disabled";
> };
>
> wdt4: watchdog@1e7850c0 {
> compatible = "aspeed,ast2600-wdt";
> + interrupts = <GIC_SPI 24 IRQ_TYPE_LEVEL_HIGH>;
> reg = <0x1e7850C0 0x40>;
> status = "disabled";
> };
prev parent reply other threads:[~2022-11-02 21:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-01 20:53 [PATCH v2 0/2] watchdog: aspeed: Add pre-timeout interrupt support Eddie James
2022-11-01 20:53 ` [PATCH v2 1/2] watchdog: aspeed: Enable pre-timeout interrupt Eddie James
2022-11-02 20:59 ` Guenter Roeck
2022-11-01 20:53 ` [PATCH v2 2/2] ARM: dts: aspeed: Setup watchdog " Eddie James
2022-11-02 21:00 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221102210033.GA2090211@roeck-us.net \
--to=linux@roeck-us.net \
--cc=andrew@aj.id.au \
--cc=eajames@linux.ibm.com \
--cc=joel@jms.id.au \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox