Re: [PATCH v2 11/15] scsi: ufs: ufs-qcom: Use dev_err_probe() for printing probe error

Andrew Halaney
2022-10-31T20:06:55Z

On Mon, Oct 31, 2022 at 11:32:13PM +0530, Manivannan Sadhasivam wrote:
> Make use of dev_err_probe() for printing the probe error.
>
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>

Reviewed-by: Andrew Halaney <ahalaney@redhat.com>

> ---
> drivers/ufs/host/ufs-qcom.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c
> index 8bb0f4415f1a..38e2ed749d75 100644
> --- a/drivers/ufs/host/ufs-qcom.c
> +++ b/drivers/ufs/host/ufs-qcom.c
> @@ -1441,9 +1441,9 @@ static int ufs_qcom_probe(struct platform_device *pdev)
> /* Perform generic probe */
> err = ufshcd_pltfrm_init(pdev, &ufs_hba_qcom_vops);
> if (err)
> - dev_err(dev, "ufshcd_pltfrm_init() failed %d\n", err);
> + return dev_err_probe(dev, err, "ufshcd_pltfrm_init() failed\n");
>
> - return err;
> + return 0;
> }
>
> /**
> --
> 2.25.1
>