From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4D9CC4332F for ; Thu, 3 Nov 2022 12:55:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230011AbiKCMzp (ORCPT ); Thu, 3 Nov 2022 08:55:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39520 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229637AbiKCMzl (ORCPT ); Thu, 3 Nov 2022 08:55:41 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8CDD926E8; Thu, 3 Nov 2022 05:55:40 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 337F761DD5; Thu, 3 Nov 2022 12:55:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8B9FDC433D7; Thu, 3 Nov 2022 12:55:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1667480139; bh=FQsgWu/Pnd3ynxozqQF9/wuhkpto1AVQEAGm/DwNevs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jUJDZ46i4KY5p8LXoeP/oMAGWPY8t90juY9t+cw+9gX7zv/9KQA7RgM7IVMggfcEe 8HRNKkKO9rFxahO+lA4UiLrfsS0eFhWoecc7LjPrUrx521pzehZk1J8HezkLWuLbDE 8gg/2qslvj9Xm726/egZ6hiBDrjg6a1qsZWYN7v13veBs5YYap36Y8pmxDvbb7P1q6 oto6VBjjlIjazLGhakP+iq/dEtTos9OYrQ6fEKOBeGadbLpAFPm4yx9hQCuN9QUZIz r+9HLHrjJBWyvgcmsS5YaWc6gXbvbIIpjI3rHHc+PjnHzSAQlfk6acw/VYyD+5DrkT cv7t/mWb4bWrQ== Date: Thu, 3 Nov 2022 18:25:31 +0530 From: Manivannan Sadhasivam To: Qiang Yu Cc: quic_hemantk@quicinc.com, loic.poulain@linaro.org, mhi@lists.linux.dev, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, quic_cang@quicinc.com, mrana@quicinc.com Subject: Re: [PATCH] bus: mhi: host: Add session ID to MHI controller Message-ID: <20221103125531.GI8434@thinkpad> References: <1665376870-60668-1-git-send-email-quic_qianyu@quicinc.com> <20221028172022.GC13880@thinkpad> <7dc5b87a-1413-f7cb-4fdc-93828252c4f1@quicinc.com> <20221101114554.GD54667@thinkpad> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20221101114554.GD54667@thinkpad> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 01, 2022 at 05:15:54PM +0530, Manivannan Sadhasivam wrote: > On Mon, Oct 31, 2022 at 04:54:55PM +0800, Qiang Yu wrote: > > > > On 10/29/2022 1:20 AM, Manivannan Sadhasivam wrote: > > > On Mon, Oct 10, 2022 at 12:41:10PM +0800, Qiang Yu wrote: > > > > Session ID to be used during BHI transfers to recognize a > > > > particular session are currently not being stored in the MHI > > > > controller structure. Store them to allow for tracking and other > > > > future usage. > > > > > > > > Signed-off-by: Qiang Yu > > > Who/what is going to use this session id? > > Sometimes, we may find some error logs and want to see what happens on > > device when host is printing these error logs. > > Session id can help us find the logs we want. > > Okay. Please add this info to the commit message. > Wait. I asked who is going to use session_id cached in the MHI controller structure? session_id is already printed in debug log. > Thanks, > Mani > > > > > > > Thanks, > > > Mani > > > > > > > --- > > > > drivers/bus/mhi/host/boot.c | 8 ++++---- > > > > include/linux/mhi.h | 1 + > > > > 2 files changed, 5 insertions(+), 4 deletions(-) > > > > > > > > diff --git a/drivers/bus/mhi/host/boot.c b/drivers/bus/mhi/host/boot.c > > > > index 26d0edd..5bed8b51 100644 > > > > --- a/drivers/bus/mhi/host/boot.c > > > > +++ b/drivers/bus/mhi/host/boot.c > > > > @@ -231,7 +231,7 @@ static int mhi_fw_load_bhi(struct mhi_controller *mhi_cntrl, > > > > dma_addr_t dma_addr, > > > > size_t size) > > > > { > > > > - u32 tx_status, val, session_id; > > > > + u32 tx_status, val; > > > > int i, ret; > > > > void __iomem *base = mhi_cntrl->bhi; > > > > rwlock_t *pm_lock = &mhi_cntrl->pm_lock; > > > > @@ -253,16 +253,16 @@ static int mhi_fw_load_bhi(struct mhi_controller *mhi_cntrl, > > > > goto invalid_pm_state; > > > > } > > > > - session_id = MHI_RANDOM_U32_NONZERO(BHI_TXDB_SEQNUM_BMSK); > > > > + mhi_cntrl->session_id = MHI_RANDOM_U32_NONZERO(BHI_TXDB_SEQNUM_BMSK); > > > > dev_dbg(dev, "Starting image download via BHI. Session ID: %u\n", > > > > - session_id); > > > > + mhi_cntrl->session_id); > > > > mhi_write_reg(mhi_cntrl, base, BHI_STATUS, 0); > > > > mhi_write_reg(mhi_cntrl, base, BHI_IMGADDR_HIGH, > > > > upper_32_bits(dma_addr)); > > > > mhi_write_reg(mhi_cntrl, base, BHI_IMGADDR_LOW, > > > > lower_32_bits(dma_addr)); > > > > mhi_write_reg(mhi_cntrl, base, BHI_IMGSIZE, size); > > > > - mhi_write_reg(mhi_cntrl, base, BHI_IMGTXDB, session_id); > > > > + mhi_write_reg(mhi_cntrl, base, BHI_IMGTXDB, mhi_cntrl->session_id); > > > > read_unlock_bh(pm_lock); > > > > /* Wait for the image download to complete */ > > > > diff --git a/include/linux/mhi.h b/include/linux/mhi.h > > > > index a5441ad..8b3c934 100644 > > > > --- a/include/linux/mhi.h > > > > +++ b/include/linux/mhi.h > > > > @@ -405,6 +405,7 @@ struct mhi_controller { > > > > u32 minor_version; > > > > u32 serial_number; > > > > u32 oem_pk_hash[MHI_MAX_OEM_PK_HASH_SEGMENTS]; > > > > + u32 session_id; > > > > struct mhi_event *mhi_event; > > > > struct mhi_cmd *mhi_cmd; > > > > -- > > > > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > > > > a Linux Foundation Collaborative Project > > > > > > > > > > > > -- > மணிவண்ணன் சதாசிவம் > -- மணிவண்ணன் சதாசிவம்