From: Steven Rostedt <rostedt@goodmis.org>
To: linux-kernel@vger.kernel.org
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
Stephen Boyd <sboyd@kernel.org>,
Guenter Roeck <linux@roeck-us.net>,
Anna-Maria Gleixner <anna-maria@linutronix.de>,
Andrew Morton <akpm@linux-foundation.org>,
David Rheinsberg <david.rheinsberg@gmail.com>,
Jiri Kosina <jikos@kernel.org>,
Benjamin Tissoires <benjamin.tissoires@redhat.com>,
linux-input@vger.kernel.org
Subject: [RFC][PATCH v3 14/33] timers: HID: Use timer_shutdown_sync() before freeing timer
Date: Fri, 04 Nov 2022 01:41:07 -0400 [thread overview]
Message-ID: <20221104054914.458495869@goodmis.org> (raw)
In-Reply-To: 20221104054053.431922658@goodmis.org
From: "Steven Rostedt (Google)" <rostedt@goodmis.org>
Before a timer is freed, timer_shutdown_sync() must be called.
Link: https://lore.kernel.org/all/20220407161745.7d6754b3@gandalf.local.home/
Cc: David Rheinsberg <david.rheinsberg@gmail.com>
Cc: Jiri Kosina <jikos@kernel.org>
Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc: linux-input@vger.kernel.org
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
---
drivers/hid/hid-wiimote-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hid/hid-wiimote-core.c b/drivers/hid/hid-wiimote-core.c
index 4399d6c6afef..2c94308dda3c 100644
--- a/drivers/hid/hid-wiimote-core.c
+++ b/drivers/hid/hid-wiimote-core.c
@@ -1764,7 +1764,7 @@ static void wiimote_destroy(struct wiimote_data *wdata)
spin_unlock_irqrestore(&wdata->state.lock, flags);
cancel_work_sync(&wdata->init_worker);
- del_timer_sync(&wdata->timer);
+ timer_shutdown_sync(&wdata->timer);
device_remove_file(&wdata->hdev->dev, &dev_attr_devtype);
device_remove_file(&wdata->hdev->dev, &dev_attr_extension);
--
2.35.1
next prev parent reply other threads:[~2022-11-04 5:49 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-04 5:40 [RFC][PATCH v3 00/33] timers: Use timer_shutdown*() before freeing timers Steven Rostedt
2022-11-04 5:40 ` [RFC][PATCH v3 01/33] timers: Add timer_shutdown_sync() and timer_shutdown() to be called " Steven Rostedt
2022-11-04 5:40 ` [RFC][PATCH v3 02/33] timers: s390/cmm: Use timer_shutdown_sync() before freeing timer Steven Rostedt
2022-11-04 5:40 ` [RFC][PATCH v3 03/33] timers: sh: " Steven Rostedt
2022-11-04 5:40 ` [RFC][PATCH v3 05/33] timers: ACPI: " Steven Rostedt
2022-11-07 15:47 ` Jarkko Sakkinen
2022-11-04 5:40 ` [RFC][PATCH v3 06/33] timers: atm: " Steven Rostedt
2022-11-04 5:41 ` [RFC][PATCH v3 07/33] timers: PM: Use timer_shutdown_sync() Steven Rostedt
2022-11-04 5:41 ` [RFC][PATCH v3 08/33] timers: Bluetooth: Use timer_shutdown_sync() before freeing timer Steven Rostedt
2022-11-04 5:41 ` [RFC][PATCH v3 09/33] timers: hangcheck: " Steven Rostedt
2022-11-04 5:41 ` [RFC][PATCH v3 10/33] timers: ipmi: " Steven Rostedt
2022-11-04 5:41 ` [RFC][PATCH v3 11/33] random: use " Steven Rostedt
2022-11-04 5:41 ` Steven Rostedt [this message]
2022-11-04 5:41 ` [RFC][PATCH v3 16/33] timers: mISDN: Use " Steven Rostedt
2022-11-04 5:41 ` [RFC][PATCH v3 17/33] timers: leds: " Steven Rostedt
2022-11-04 5:41 ` [RFC][PATCH v3 19/33] timers: net: " Steven Rostedt
2022-11-04 5:41 ` [RFC][PATCH v3 20/33] timers: usb: " Steven Rostedt
2022-11-04 5:41 ` [RFC][PATCH v3 21/33] timers: cgroup: " Steven Rostedt
2022-11-04 5:41 ` [RFC][PATCH v3 22/33] timers: workqueue: " Steven Rostedt
2022-11-04 5:41 ` [RFC][PATCH v3 23/33] timers: nfc: pn533: " Steven Rostedt
2022-11-04 15:46 ` Krzysztof Kozlowski
2022-11-05 5:25 ` Steven Rostedt
2022-11-04 5:41 ` [RFC][PATCH v3 24/33] timers: pcmcia: " Steven Rostedt
2022-11-04 5:41 ` [RFC][PATCH v3 25/33] timers: scsi: Use timer_shutdown_sync() and timer_shutdown() " Steven Rostedt
2022-11-04 5:41 ` [RFC][PATCH v3 26/33] timers: tty: Use timer_shutdown_sync() " Steven Rostedt
2022-11-04 5:41 ` [RFC][PATCH v3 27/33] timers: ext4: " Steven Rostedt
2022-11-04 5:41 ` [RFC][PATCH v3 28/33] timers: fs/nilfs2: " Steven Rostedt
2022-11-04 6:57 ` Ryusuke Konishi
2022-11-04 18:54 ` Steven Rostedt
2022-11-04 5:41 ` [RFC][PATCH v3 29/33] timers: ALSA: " Steven Rostedt
2022-11-04 8:11 ` Takashi Iwai
2022-11-04 5:41 ` [RFC][PATCH v3 30/33] timers: jbd2: Use timer_shutdown() " Steven Rostedt
2022-11-07 12:37 ` Jan Kara
2022-11-04 5:41 ` [RFC][PATCH v3 31/33] timers: sched/psi: Use timer_shutdown_sync() " Steven Rostedt
2022-11-04 20:11 ` Johannes Weiner
2022-11-04 20:29 ` Suren Baghdasaryan
2022-11-04 5:41 ` [RFC][PATCH v3 32/33] timers: x86/mce: Use __init_timer() for resetting timers Steven Rostedt
2022-11-04 5:41 ` [RFC][PATCH v3 33/33] timers: Expand DEBUG_OBJECTS_TIMER to check if it ever was used Steven Rostedt
[not found] ` <20221104054914.085569465@goodmis.org>
2022-11-04 5:54 ` [RFC][PATCH v3 12/33] timers: dma-buf: Use timer_shutdown_sync() before freeing timer Steven Rostedt
2022-11-04 7:15 ` Christian König
2022-11-04 18:58 ` Steven Rostedt
2022-11-05 8:12 ` [Linaro-mm-sig] " Christian König
[not found] ` <20221104054914.271196777@goodmis.org>
2022-11-04 5:55 ` [RFC][PATCH v3 13/33] timers: drm: " Steven Rostedt
2022-11-04 8:48 ` Tvrtko Ursulin
2022-11-04 19:02 ` Steven Rostedt
[not found] ` <20221104054912.617055044@goodmis.org>
2022-11-04 5:56 ` [RFC][PATCH v3 04/33] timers: block: " Steven Rostedt
[not found] ` <20221104054915.190085802@goodmis.org>
2022-11-04 5:57 ` [RFC][PATCH v3 18/33] timers: media: " Steven Rostedt
2022-11-04 17:00 ` [RFC][PATCH v3 00/33] timers: Use timer_shutdown*() before freeing timers Linus Torvalds
2022-11-04 19:22 ` Guenter Roeck
2022-11-04 19:42 ` Steven Rostedt
2022-11-04 19:50 ` Linus Torvalds
2022-11-04 20:38 ` Steven Rostedt
2022-11-04 20:42 ` Guenter Roeck
2022-11-04 20:41 ` Guenter Roeck
2022-11-04 23:34 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221104054914.458495869@goodmis.org \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=anna-maria@linutronix.de \
--cc=benjamin.tissoires@redhat.com \
--cc=david.rheinsberg@gmail.com \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=sboyd@kernel.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox