From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F090C4321E for ; Fri, 4 Nov 2022 19:35:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229499AbiKDTf2 (ORCPT ); Fri, 4 Nov 2022 15:35:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33230 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229523AbiKDTfY (ORCPT ); Fri, 4 Nov 2022 15:35:24 -0400 Received: from mail-pg1-x529.google.com (mail-pg1-x529.google.com [IPv6:2607:f8b0:4864:20::529]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2D66045088 for ; Fri, 4 Nov 2022 12:35:24 -0700 (PDT) Received: by mail-pg1-x529.google.com with SMTP id 136so1339150pga.1 for ; Fri, 04 Nov 2022 12:35:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=content-disposition:mime-version:message-id:subject:cc:to:date:from :from:to:cc:subject:date:message-id:reply-to; bh=Fi3uLXH+szzqTxRSWVS63wUkqoaeAU4TkZNAaOvVK+s=; b=aWx+oPO+Srbo1w+pEL6tCCG2kMxu7Owtr3UvsxPEkOsAPbsNEoWsMP/nloh4Xfxmjt yAPc0edxVQcVDqNuzsSO7GcAU0weBGcazqHv85VCQxprA0/+UVoKiaaE+p7ftEd7g2sC TGxq/1cx5xFlVcjBZr75s1UfKRd0G0E9umQIQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-disposition:mime-version:message-id:subject:cc:to:date:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Fi3uLXH+szzqTxRSWVS63wUkqoaeAU4TkZNAaOvVK+s=; b=HE4iJ9opJQ1a1gujsznKyTVpTKOiLSVyMvkh8gMDrtT0f8qke3KQDbdzgUaloDeuq4 j4P3BfAYzvZKo9PBX1/UIsJ8+fstRKrTg0XRhCJEdXfQNRWqxCgijhDyKu8SE15j0CQu KYsXk2XdMn6QZC4mlfpy4sv2BQU5GisQP5ljYj4jlggv1RhX0qI+NSouqpYFj0hE8qXe Uj7WyQ7gOsKmMgbQQyJK7fn7uK0ZLhBdBh+kXnunKPUMg9Gi3c5AsGwoOOvIQjqUddAK bRGw42YxNFh2jerNRdN2HgM6OvRsQmEbsm4pt17ZuMCWtHB6wGFrkw18CcV5OCraXXr9 9ZXw== X-Gm-Message-State: ACrzQf24/7m4yBzhjEV+hqsdswdPvDhircgejbs/8+Zb7ea7ThIbLYxH a8XWYQb0RyDbeWrNRh/868mCkA== X-Google-Smtp-Source: AMsMyM7t+PovjIzz0bK0Dmex/GB5uaGqzigeaTOQYl4Zm0s+THtQgtXB0FMtorvOI4GBtIiH/aigqg== X-Received: by 2002:a05:6a00:4508:b0:56d:8afe:b7c1 with SMTP id cw8-20020a056a00450800b0056d8afeb7c1mr25958465pfb.29.1667590523697; Fri, 04 Nov 2022 12:35:23 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id i16-20020a632210000000b0043a18cef977sm109241pgi.13.2022.11.04.12.35.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Nov 2022 12:35:23 -0700 (PDT) From: coverity-bot X-Google-Original-From: coverity-bot Date: Fri, 4 Nov 2022 12:35:22 -0700 To: Crt Mori Cc: linux-iio@vger.kernel.org, Lars-Peter Clausen , linux-kernel@vger.kernel.org, Jonathan Cameron , Jonathan Cameron , "Gustavo A. R. Silva" , linux-next@vger.kernel.org, linux-hardening@vger.kernel.org Subject: Coverity: mlx90632_probe(): Error handling issues Message-ID: <202211041235.FB1AF7F6F@keescook> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello! This is an experimental semi-automated report about issues detected by Coverity from a scan of next-20221104 as part of the linux-next scan project: https://scan.coverity.com/projects/linux-next-weekly-scan You're getting this email because you were associated with the identified lines of code (noted below) that were touched by commits: Thu Nov 3 21:42:26 2022 +0000 c83d3e5ca97f ("iio: temperature: mlx90632 Add runtime powermanagement modes") Coverity reported the following: *** CID 1527134: Error handling issues (CHECKED_RETURN) drivers/iio/temperature/mlx90632.c:1270 in mlx90632_probe() 1264 mlx90632->object_ambient_temperature = 25000; /* 25 degrees milliCelsius */ 1265 mlx90632->interaction_ts = jiffies; /* Set initial value */ 1266 1267 pm_runtime_get_noresume(&client->dev); 1268 pm_runtime_set_active(&client->dev); 1269 vvv CID 1527134: Error handling issues (CHECKED_RETURN) vvv Calling "devm_pm_runtime_enable" without checking return value (as is done elsewhere 21 out of 24 times). 1270 devm_pm_runtime_enable(&client->dev); 1271 pm_runtime_set_autosuspend_delay(&client->dev, MLX90632_SLEEP_DELAY_MS); 1272 pm_runtime_use_autosuspend(&client->dev); 1273 pm_runtime_put_autosuspend(&client->dev); 1274 1275 return devm_iio_device_register(&client->dev, indio_dev); If this is a false positive, please let us know so we can mark it as such, or teach the Coverity rules to be smarter. If not, please make sure fixes get into linux-next. :) For patches fixing this, please include these lines (but double-check the "Fixes" first): Reported-by: coverity-bot Addresses-Coverity-ID: 1527134 ("Error handling issues") Fixes: c83d3e5ca97f ("iio: temperature: mlx90632 Add runtime powermanagement modes") Thanks for your attention! -- Coverity-bot