From: Antonio Gomes <antoniospg100@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: antoniospg100@gmail.com, Ben Skeggs <bskeggs@redhat.com>,
Karol Herbst <kherbst@redhat.com>, Lyude Paul <lyude@redhat.com>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org
Subject: [PATCH v3] drm/nouveau: Add support to control backlight using bl_power for nva3.
Date: Fri, 4 Nov 2022 19:01:21 -0300 [thread overview]
Message-ID: <20221104220122.38622-1-antoniospg100@gmail.com> (raw)
In-Reply-To: <20221031163211.13228-1-antoniospg100@gmail.com>
From: antoniospg <antoniospg100@gmail.com>
Summary:
* Add support to turn on/off backlight when changing values in bl_power
file. This is achieved by using function backlight_get_brightness()
in nva3_set_intensity to get current brightness.
Test plan:
* Turn off:
echo 1 > /sys/class/backlight/nv_backlight/bl_power
* Turn on:
echo 0 > /sys/class/backlight/nv_backlight/bl_power
Signed-off-by: antoniospg <antoniospg100@gmail.com>
---
drivers/gpu/drm/nouveau/nouveau_backlight.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/nouveau/nouveau_backlight.c b/drivers/gpu/drm/nouveau/nouveau_backlight.c
index a2141d3d9b1d..5c82f5189b79 100644
--- a/drivers/gpu/drm/nouveau/nouveau_backlight.c
+++ b/drivers/gpu/drm/nouveau/nouveau_backlight.c
@@ -263,7 +263,11 @@ nva3_set_intensity(struct backlight_device *bd)
u32 div, val;
div = nvif_rd32(device, NV50_PDISP_SOR_PWM_DIV(or));
- val = (bd->props.brightness * div) / 100;
+
+ val = backlight_get_brightness(bd);
+ if (val)
+ val = (val * div) / 100;
+
if (div) {
nvif_wr32(device, NV50_PDISP_SOR_PWM_CTL(or),
val |
--
2.25.1
next prev parent reply other threads:[~2022-11-04 22:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-29 18:48 [PATCH] drm/nouveau: Adding support to control backlight using bl_power for nva3 antoniospg
2022-10-30 13:05 ` Bagas Sanjaya
2022-10-30 20:48 ` Sam Ravnborg
2022-10-31 16:32 ` [PATCH] drm/nouveau: Add " antoniospg
2022-11-01 2:11 ` Bagas Sanjaya
2022-11-01 10:41 ` Karol Herbst
2022-11-04 22:01 ` Antonio Gomes [this message]
2022-11-04 22:04 ` [PATCH v3] " Antonio Gomes
2022-11-09 17:08 ` Karol Herbst
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221104220122.38622-1-antoniospg100@gmail.com \
--to=antoniospg100@gmail.com \
--cc=airlied@linux.ie \
--cc=bskeggs@redhat.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=kherbst@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lyude@redhat.com \
--cc=nouveau@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox